asterisk users - Feb 2005 - Is there a Caller ID issue in the latest CVSStable

Nicol?s Gudi?o <asternic@gmail.com> wrote:
>>> Paul, 1.0.5 stable suffers from caller id issues as well, at least
for
>>> SIP channels. What fixed things for me was swapping in app_dial.c
from
>>> 1.0.2 stable (didn't try others). You could also just diff
app_dial.c
>>> between versions to find the problem but I took the lazy way out
the
>>> first time around.
> 
> 
> Drumkilla reverted the callerid changes on the latest stable (thanks
> Russell!). You will be fine if you checkout stable from CVS now.
Hmmm; I think I'm still having problems with it, using a completely 
fresh checkout and compile:
Connected to Asterisk CVS-v1-0-02/11/05-17:34:08

I have two Zap FXS lines and two SIP phones, and:

- Zap channel to Zap channel, caller ID works (displays correctly on the 
analog phone display).
- SIP phone to Zap channel, caller ID works.
- SIP phone to ZIP phone, caller ID does NOT work (Grandstream phone 
displays "Err").
- Zap channel to SIP phone, caller ID does NOT work.
- Incoming Free World Dialup calls to Zap channel extension, caller ID 
works.
- Incoming Free World Dialup calls to SIP phone extension, caller ID 
does NOT work.

So it seems that asterisk stable, as of today, does not send correct 
caller ID on calls that end up on SIP phones, unless I'm doing something 
boneheaded (although I used almost-identical config files on 1.0.2 with 
no trouble).

A tcpdump shows that asterisk is sending this in the SIP INVITE header 
to the phone:

From: "asterisk" <sip:asterisk@10.1.2.3>;

(IP address obscured; it's correct in the original.) But somehow 
"asterisk" appears instead of the correct caller ID. Wasn't that
the bug
other people were seeing that the stable update was supposed to fix? 
Have I missed something obvious?

-- 
Robert L Mathews, Tiger Technologies       http://www.tigertech.net/

(Intentional top-post, due to relative brevity of answer)

The error is a typo in the latest chan_sip.c in Stable. See my note on
Mantis bug #3557 (softins).

To fix, find line 3673 and change ast_isphonenumber(l) to !ast_isphonenumber(l)

CVS HEAD does not have the typo, so is OK.

Cheers
Tony

Robert L Mathews <lists@tigertech.com> wrote:
> Nicol?s Gudi?o <asternic@gmail.com> wrote:
> 
> >>> Paul, 1.0.5 stable suffers from caller id issues as well, at
least for
> >>> SIP channels. What fixed things for me was swapping in
app_dial.c from
> >>> 1.0.2 stable (didn't try others). You could also just diff
app_dial.c
> >>> between versions to find the problem but I took the lazy way
out the
> >>> first time around.
> > 
> > Drumkilla reverted the callerid changes on the latest stable (thanks
> > Russell!). You will be fine if you checkout stable from CVS now.
> 
> Hmmm; I think I'm still having problems with it, using a completely 
> fresh checkout and compile:
> Connected to Asterisk CVS-v1-0-02/11/05-17:34:08
> 
> I have two Zap FXS lines and two SIP phones, and:
> 
> - Zap channel to Zap channel, caller ID works (displays correctly on the 
> analog phone display).
> - SIP phone to Zap channel, caller ID works.
> - SIP phone to ZIP phone, caller ID does NOT work (Grandstream phone 
> displays "Err").
> - Zap channel to SIP phone, caller ID does NOT work.
> - Incoming Free World Dialup calls to Zap channel extension, caller ID 
> works.
> - Incoming Free World Dialup calls to SIP phone extension, caller ID 
> does NOT work.
> 
> So it seems that asterisk stable, as of today, does not send correct 
> caller ID on calls that end up on SIP phones, unless I'm doing
something
> boneheaded (although I used almost-identical config files on 1.0.2 with 
> no trouble).
> 
> A tcpdump shows that asterisk is sending this in the SIP INVITE header 
> to the phone:
> 
> From: "asterisk" <sip:asterisk@10.1.2.3>;
> 
> (IP address obscured; it's correct in the original.) But somehow 
> "asterisk" appears instead of the correct caller ID. Wasn't
that the bug
> other people were seeing that the stable update was supposed to fix? 
> Have I missed something obvious?
> 
> -- 
> Robert L Mathews, Tiger Technologies       http://www.tigertech.net/
-- 
Tony Mountifield
Work: tony@softins.co.uk - http://www.softins.co.uk
Play: tony@mountifield.org - http://tony.mountifield.org

I your case the problem is with the grandstream, the GS will not
display callerID correctly, take out the name from the callerid string
like this:
exten => ${EXTEN},PRI,SetCallerID(${CALLERIDNUM})



On Fri, 11 Feb 2005 23:46:13 -0800, Robert L Mathews
<lists@tigertech.com> wrote:
> Nicol?s Gudi?o <asternic@gmail.com> wrote:
> 
> >>> Paul, 1.0.5 stable suffers from caller id issues as well, at
least for
> >>> SIP channels. What fixed things for me was swapping in
app_dial.c from
> >>> 1.0.2 stable (didn't try others). You could also just diff
app_dial.c
> >>> between versions to find the problem but I took the lazy way
out the
> >>> first time around.
> >
> >
> > Drumkilla reverted the callerid changes on the latest stable (thanks
> > Russell!). You will be fine if you checkout stable from CVS now.
> 
> Hmmm; I think I'm still having problems with it, using a completely
> fresh checkout and compile:
> Connected to Asterisk CVS-v1-0-02/11/05-17:34:08
> 
> I have two Zap FXS lines and two SIP phones, and:
> 
> - Zap channel to Zap channel, caller ID works (displays correctly on the
> analog phone display).
> - SIP phone to Zap channel, caller ID works.
> - SIP phone to ZIP phone, caller ID does NOT work (Grandstream phone
> displays "Err").
> - Zap channel to SIP phone, caller ID does NOT work.
> - Incoming Free World Dialup calls to Zap channel extension, caller ID
> works.
> - Incoming Free World Dialup calls to SIP phone extension, caller ID
> does NOT work.
> 
> So it seems that asterisk stable, as of today, does not send correct
> caller ID on calls that end up on SIP phones, unless I'm doing
something
> boneheaded (although I used almost-identical config files on 1.0.2 with
> no trouble).
> 
> A tcpdump shows that asterisk is sending this in the SIP INVITE header
> to the phone:
> 
> From: "asterisk" <sip:asterisk@10.1.2.3>;
> 
> (IP address obscured; it's correct in the original.) But somehow
> "asterisk" appears instead of the correct caller ID. Wasn't
that the bug
> other people were seeing that the stable update was supposed to fix?
> Have I missed something obvious?
> 
> --
> Robert L Mathews, Tiger Technologies       http://www.tigertech.net/
> 
> _______________________________________________
> Asterisk-Users mailing list
> Asterisk-Users@lists.digium.com
> http://lists.digium.com/mailman/listinfo/asterisk-users
> To UNSUBSCRIBE or update options visit:
>    http://lists.digium.com/mailman/listinfo/asterisk-users
>

C F <shmaltz@gmail.com> wrote:
> I your case the problem is with the grandstream, the GS will not
> display callerID correctly, take out the name from the callerid string
> like this:
> exten => ${EXTEN},PRI,SetCallerID(${CALLERIDNUM})
Actually, Tony Mountifield pointed out that the problem is a bug in CVS 
stable:

   http://bugs.digium.com/bug_view_page.php?bug_id=0003557

(Thanks, Tony!)

With this bug fixed, the Grandstream phones work fine even with the 
caller ID name present. They don't display the name, but they do display 
the number properly. The problem I was mentioning made it not even 
display the number correctly, on any SIP phone.

-- 
Robert L Mathews, Tiger Technologies    http://www.tigertech.net/