ZVOL was recently converted to use range locking, but it seems the comment below wasn''t updated: /* * There must be no buffer changes when doing a dmu_sync() * because * we can''t change the data whilst calculating the checksum. * A better approach than a per zvol rwlock would be to lock * ranges. */ -- Pawel Jakub Dawidek http://www.wheel.pl pjd at FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: not available URL: <http://mail.opensolaris.org/pipermail/zfs-code/attachments/20070315/21e359d3/attachment.bin>
Thanks. That would be my fault. I forgot to remove the comment. I''ll file a bug. Neil. Pawel Jakub Dawidek wrote On 03/15/07 10:59,:> ZVOL was recently converted to use range locking, but it seems the > comment below wasn''t updated: > > /* > * There must be no buffer changes when doing a dmu_sync() > * because > * we can''t change the data whilst calculating the checksum. > * A better approach than a per zvol rwlock would be to lock > * ranges. > */ > > > > ------------------------------------------------------------------------ > > _______________________________________________ > zfs-code mailing list > zfs-code at opensolaris.org > http://opensolaris.org/mailman/listinfo/zfs-code