Re: [PATCH] hvmloader: fix SeaBIOS interface

Ian Campbell
Fri, 23 Aug 2013 12:46:31 -0000

On Fri, 2013-08-23 at 13:42 +0100, Jan Beulich wrote:
> The SeaBIOS ROM image may validly exceed 128k in size, it''s only
our
> interface code that so far assumed that it wouldn''t. Remove that
> restriction by setting the base address depending on image size.
>
> Add a check to HVM loader so that too big images won''t result in
silent
> guest failure anymore.
>
> Uncomment the intended build-time size check for rombios, moving it
> into a function so that it would actually compile.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

> -    .bios_address = SEABIOS_PHYSICAL_ADDRESS,
> +    .bios_address = 0x100000 - sizeof(seabios),

Do we rely on the seabios build to pad this, or are arbitrary sizes
aloud? (Doesn''t invalidate my Ack, just curious)

Ian.