Re: [PATCH v2] x86/HVM: assorted RTC emulation adjustments

Jan Beulich
Mon, 04 Feb 2013 17:03:26 -0000

>>> On 04.02.13 at 17:51, Keir Fraser <keir@xen.org> wrote:
> On 04/02/2013 15:53, "Jan Beulich" <JBeulich@suse.com>
wrote:
>
>> - only call check_update_timer() on REG_B writes when SET changes
>> - only call alarm_timer_update() on REG_B writes when relevant bits
>>   change
>> - instead properly handle AF and PF when the guest is not also setting
>>   AIE/PIE respectively (for UF this was already the case, only a
>>   comment was slightly inaccurate), including calling the respective
>>   update functions upon REG_C reads
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> Tested-by: Olaf Hering <olaf@aepfle.de>
>
> Without spending some quality time with the RTC data sheet and our
emulation
> code, I don''t think I can usefully comment on this. Superficially
it all
> sounds reasonable. So it''s hard for me to Ack it, but you can feel
free to
> check it in anyway!

Will do, not the least because it appears to fix a problem for Olaf.

Jan