Re: [RFC PATCH] Coverage support

Frediano Ziglio
Mon, 04 Feb 2013 14:56:03 -0000

On Mon, 2013-02-04 at 09:27 +0000, Jan Beulich wrote:
> >>> On 01.02.13 at 15:48, Frediano Ziglio
<frediano.ziglio@citrix.com> wrote:
> > Updated set of patches for coverage.
> > Changes:
> > - implemented way of getting information
> > - use only 2 parameter in hypercall (still not sure it''s
better to use
> >   sysctl)
> > - use "coverage" for configuration option as suggested by
Ian Campbell
> > - split header in include/public/gcov.h and include/xen/gcov.h to
allow
> >   tools to include public header
> > - use weak to avoid defining compat_coverage_op
>
> While probably not formally documented anywhere, we decided
> against using weak some time ago.
>
> Furthermore, iirc I already told you that with a suitably defined
> interface you won''t need a compat variant at all (and in
particular
> that would be the case if you went the sysctl route, as was
> suggested to you).
>
> Jan
>

I changed today the interface to use sysctl instead of directly
hypercall. No weak symbols and easier makefiles. Still to pack updated
version (see my mail about possible license issues).

Frediano