Re: [PATCH] MCE: support cpu notification chain

Christoph Egger
Fri, 26 Oct 2012 08:24:23 -0000

On 10/25/12 16:57, Jan Beulich wrote:
>>>> On 25.10.12 at 16:45, Christoph Egger
<Christoph.Egger@amd.com> wrote:
>> On 10/25/12 16:18, Christoph Egger wrote:
>>> On 10/25/12 16:10, Jan Beulich wrote:
>>>>>>> On 25.10.12 at 15:54, Christoph Egger
<Christoph.Egger@amd.com> wrote:
>>>>> Add support for cpu notification chain.
>>>>> This is useful with nested virtualization when Xen
>>>>> runs as l1 hypervisor.
>>>>> This cleans up mce initialization cleanup as a side-effect.
>>>>
>>>> Did you notice the fix I had done to your earlier patch before
>>>> committing c/s 26106:1883c1d29de9? With the change here,
>>>> mce_clear_banks will get allocated twice (once in generic code
>>>> and once in AMD specific code), leaking one instance.
>>>
>>> Ugh... must be a merge botch.
>>
>> Updated patch attached.
>>
>> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
>
> Subject and patch don''t really fit together anymore. This is
> mostly cleanup (code movement) now, and I wonder whether
> this

Will adjust and resend.

Christoph