Re: [ PATCH 1/2] xen: enable APIC-Register Virtualization

Zhang, Yang Z
2012-09-02T23:47:32Z

Jan Beulich wrote on 2012-08-31:
>>>> On 31.08.12 at 11:29, "Li, Jiongxi"
<jiongxi.li@intel.com> wrote:
>> --- a/xen/arch/x86/hvm/vlapic.c      Fri Aug 24 12:38:18 2012 +0100
>> +++ b/xen/arch/x86/hvm/vlapic.c   Thu Aug 30 22:38:26 2012 +0800
>> @@ -823,6 +823,16 @@ static int vlapic_write(struct vcpu *v,
>>      return rc;
>> }
>>
>> +int vlapic_apicv_write(struct vcpu *v, unsigned int offset)
>> +{
>> +    uint32_t val = vlapic_get_reg(vcpu_vlapic(v), offset);
>> +
>> +    ASSERT(cpu_has_vmx_apic_reg_virt);
>
> Given the function and the assertion are in a common file, both should
> be named without using VMX specific terms (or moved elsewhere).
Correct. Since the common VM exits handlers are in vmx.c, it''s better
to put this to vmx.c too.

Best regards,
Yang
>
> Jan
>
>> +
>> +    vlapic_reg_write(v, offset, val);
>> +    return 0;
>> +}
>> +
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel