Re: [PATCH v5 09/10] libxl: call hotplug scripts for nic devices from libxl [and 1 more messages]

Roger Pau Monne
Tue, 26 Jun 2012 08:57:48 -0000

Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH v6 13/13] libxl: call hotplug scripts
for nic devices from libxl"):
>> Since most of the needed work is already done in previous patches,
>> this patch only contains the necessary code to call hotplug scripts
>> for nic devices, that should be called when the device is added or
>> removed from a guest.
>
> Thanks.
>
> Acked-by: Ian Jackson<ian.jackson@eu.citrix.com>
>
> However, AFAICT you missed this comment of mine:
>> Roger Pau Monne writes ("[PATCH v5 09/10] libxl: call hotplug
scripts for nic devices from libxl"):
>>> +int libxl__nic_type(libxl__gc *gc, libxl__device *dev,
libxl_nic_type *nictype)
>>> +{
>> ...
>>> +    }
>>> +
>>> +out:
>>> +    return rc;
>>> +}
>>> +
>> As a matter of good practice I think you should say
>>        rc = 0;
>> just before out, on the success path, and not rely on it having
>> happened to be set to 0 by the previous successful call.
>
> So IWBNI in the next version you did that too.

Sorry, I will add that and the acked-by on the next repost.

> Thanks,
> Ian.