Re: [PATCH v5 04/10] libxl: convert libxl_device_disk_add to an asyn op

Ian Jackson
Thu, 07 Jun 2012 14:20:18 -0000

Roger Pau Monne writes ("[PATCH v5 04/10] libxl: convert
libxl_device_disk_add to an asyn op"):
> This patch converts libxl_device_disk_add to an ao operation that
> waits for device backend to reach state XenbusStateInitWait and then
> marks the operation as completed. This is not really useful now, but
> will be used by latter patches that will launch hotplug scripts after
> we reached the desired xenbus state.

Just spotted:

> +void libxl__initiate_device_add(libxl__egc *egc, libxl__ao_device *aodev)
> +{
...
> +    libxl__ev_devstate_init(&aodev->ds);
> +    rc = libxl__ev_devstate_wait(gc, &aodev->ds,
device_backend_callback,
> +                                 state_path, XenbusStateInitWait,
> +                                 LIBXL_INIT_TIMEOUT * 1000);

Another unneeded _init.

I won''t comment on any more of these I find.

Ian.