Re: [PATCH 2/5] libxl: call hotplug scripts from libxl for vbd

Roger Pau Monne
Tue, 17 Apr 2012 09:13:06 -0000

El 17/04/2012, a las 09:54, Roger Pau Monne escribió:
> On Tue, 2012-04-17 at 09:54 +0100, Roger Pau Monne wrote:
>> El 16/04/2012, a las 17:44, Ian Campbell escribió:
>>>> +execute_udev=`xenstore-read $XENBUS_PATH/execute_udev
2>/dev/null`
>>>> +if [ -n "$execute_udev" ] && [ -z
"$XL_CALL" ]; then
>>>> +    exit 0
>>>> +fi
>>>
>>> So, am I right that in some future world where we have got rid of
xend
>>> and made this stuff work without udev everywhere (e.g. including
driver
>>> domains) there is a path to deprecating this snippet without
requiring
>>> everyone to go through some sort of transition?
>>>
>>> Or are we stuck with this envvar forever? It''s not a big
deal but if we
>>> can invert it (e.g. by setting
ENV{HOTPLUG_GATE}=${XENBUS}/evecute_udev
>>> in xen-backend.rules and ...if -n "${HOTPLUG_GATE}"
&& xenstore-read
>>> ${HOTPLUG_GATE}... etc) then that would be nicer?
>>
>>
>> I will change it to something like:
>>
>> if [ -z "${HOTPLUG_GATE}" ] && `xenstore-read
"$HOTPLUG_GATE" 2>/dev/null` && \
>>   [ -z "$XL_CALL" ]; then
>
> Do you still need $XL_CALL?

No, with HOTPLUG_GATE it''s enough, thanks again.

>
> Ian.
>
>
>