# HG changeset patch
# User Roger Pau Monne <roger.pau@entel.upc.edu>
# Date 1326606960 -3600
# Node ID a1986ef30b7dab4f60fe5cda70856f5751a9fde2
# Parent cd47dde439e688cac244c7eb9f55d826c85c844f
libxl: add support for yajl 2.x
This patch adds support for yajl versions 2.x, while retaining 1.x
compatibility. All the needed ifdefs can be found in libxl_json.h.
Tested with yajl 2.0.3 and 1.0.12.
Changes since v2:
* Moved all ifdefs to libxl_json.h, as Ian Jackson suggested.
Changes since v1:
* Check if yajl_version.h is present before trying to include it.
Signed-off-by: Roger Pau Monne <roger.pau@entel.upc.edu>
diff -r cd47dde439e6 -r a1986ef30b7d Config.mk
--- a/Config.mk Sat Jan 14 19:04:48 2012 +0100
+++ b/Config.mk Sun Jan 15 06:56:00 2012 +0100
@@ -181,6 +181,11 @@ CHECK_INCLUDES = $(EXTRA_INCLUDES) $(PRE
EMBEDDED_EXTRA_CFLAGS := -nopie -fno-stack-protector -fno-stack-protector-all
EMBEDDED_EXTRA_CFLAGS += -fno-exceptions
+CONFIG_YAJL_VERSION := $(shell export OS="`uname -s`"; \
+ export CHECK_INCLUDES="$(CHECK_INCLUDES)"; \
+ . $(XEN_ROOT)/tools/check/funcs.sh; \
+ has_header yajl/yajl_version.h && echo
''y'' || echo ''n'')
+
# Enable XSM security module (by default, Flask).
XSM_ENABLE ?= n
FLASK_ENABLE ?= $(XSM_ENABLE)
diff -r cd47dde439e6 -r a1986ef30b7d tools/check/check_yajl_lib
--- a/tools/check/check_yajl_lib Sat Jan 14 19:04:48 2012 +0100
+++ /dev/null Thu Jan 01 00:00:00 1970 +0000
@@ -1,6 +0,0 @@
-#!/bin/sh
-# CHECK-BUILD CHECK-INSTALL
-
-. ./funcs.sh
-
-has_lib libyajl.so.1 || fail "can''t find libyajl.so.1 version
1"
diff -r cd47dde439e6 -r a1986ef30b7d tools/libxl/Makefile
--- a/tools/libxl/Makefile Sat Jan 14 19:04:48 2012 +0100
+++ b/tools/libxl/Makefile Sun Jan 15 06:56:00 2012 +0100
@@ -19,6 +19,10 @@ ifeq ($(CONFIG_Linux),y)
LIBUUID_LIBS += -luuid
endif
+ifeq ($(CONFIG_YAJL_VERSION),y)
+CFLAGS += -DHAVE_YAJL_VERSION
+endif
+
LIBXL_LIBS LIBXL_LIBS = $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest)
$(LDLIBS_libxenstore) $(LDLIBS_libblktapctl) $(UTIL_LIBS) $(LIBUUID_LIBS)
diff -r cd47dde439e6 -r a1986ef30b7d tools/libxl/libxl_json.c
--- a/tools/libxl/libxl_json.c Sat Jan 14 19:04:48 2012 +0100
+++ b/tools/libxl/libxl_json.c Sun Jan 15 06:56:00 2012 +0100
@@ -519,7 +519,7 @@ static bool is_decimal(const char *s, un
return false;
}
-static int json_callback_number(void *opaque, const char *s, unsigned int len)
+static int json_callback_number(void *opaque, const char *s, libxl_yajl_length
len)
{
libxl__yajl_ctx *ctx = opaque;
libxl__json_object *obj = NULL;
@@ -576,7 +576,7 @@ out:
}
static int json_callback_string(void *opaque, const unsigned char *str,
- unsigned int len)
+ libxl_yajl_length len)
{
libxl__yajl_ctx *ctx = opaque;
char *t = NULL;
@@ -609,7 +609,7 @@ static int json_callback_string(void *op
}
static int json_callback_map_key(void *opaque, const unsigned char *str,
- unsigned int len)
+ libxl_yajl_length len)
{
libxl__yajl_ctx *ctx = opaque;
char *t = NULL;
@@ -772,17 +772,13 @@ libxl__json_object *libxl__json_parse(li
DEBUG_GEN_ALLOC(&yajl_ctx);
if (yajl_ctx.hand == NULL) {
- yajl_parser_config cfg = {
- .allowComments = 1,
- .checkUTF8 = 1,
- };
- yajl_ctx.hand = yajl_alloc(&callbacks, &cfg, NULL,
&yajl_ctx);
+ yajl_ctx.hand = libxl__yajl_alloc(&callbacks, NULL, &yajl_ctx);
}
status = yajl_parse(yajl_ctx.hand, (const unsigned char *)s, strlen(s));
if (status != yajl_status_ok)
goto out;
- status = yajl_parse_complete(yajl_ctx.hand);
+ status = yajl_complete_parse(yajl_ctx.hand);
if (status != yajl_status_ok)
goto out;
@@ -834,14 +830,13 @@ static const char *yajl_gen_status_to_st
char *libxl__object_to_json(libxl_ctx *ctx, const char *type,
libxl__gen_json_callback gen, void *p)
{
- yajl_gen_config conf = { 1, " " };
const unsigned char *buf;
char *ret = NULL;
- unsigned int len = 0;
+ libxl_yajl_length len = 0;
yajl_gen_status s;
yajl_gen hand;
- hand = yajl_gen_alloc(&conf, NULL);
+ hand = libxl__yajl_gen_alloc(NULL);
if (!hand)
return NULL;
diff -r cd47dde439e6 -r a1986ef30b7d tools/libxl/libxl_json.h
--- a/tools/libxl/libxl_json.h Sat Jan 14 19:04:48 2012 +0100
+++ b/tools/libxl/libxl_json.h Sun Jan 15 06:56:00 2012 +0100
@@ -16,8 +16,55 @@
#define LIBXL_JSON_H
#include <yajl/yajl_gen.h>
+#include <yajl/yajl_parse.h>
+
+#ifdef HAVE_YAJL_VERSION
+# include <yajl/yajl_version.h>
+#endif
#include <_libxl_types_json.h>
#include <_libxl_types_internal_json.h>
+/* YAJL version check */
+#if defined(YAJL_MAJOR) && (YAJL_MAJOR > 1)
+# define HAVE_YAJL_V2 1
+#endif
+
+#ifdef HAVE_YAJL_V2
+typedef size_t libxl_yajl_length;
+
+static inline yajl_handle libxl__yajl_alloc(const yajl_callbacks *callbacks,
+ yajl_alloc_funcs *allocFuncs,
+ void *ctx)
+{
+ return yajl_alloc(callbacks, allocFuncs, ctx);
+}
+
+static inline yajl_gen libxl__yajl_gen_alloc(const yajl_alloc_funcs
*allocFuncs)
+{
+ return yajl_gen_alloc(allocFuncs);
+}
+#else
+#define yajl_complete_parse yajl_parse_complete
+
+typedef unsigned int libxl_yajl_length;
+
+static inline yajl_handle libxl__yajl_alloc(const yajl_callbacks *callbacks,
+ const yajl_alloc_funcs *allocFuncs,
+ void *ctx)
+{
+ yajl_parser_config cfg = {
+ .allowComments = 1,
+ .checkUTF8 = 1,
+ };
+ return yajl_alloc(callbacks, &cfg, allocFuncs, ctx);
+}
+
+static inline yajl_gen libxl__yajl_gen_alloc(const yajl_alloc_funcs
*allocFuncs)
+{
+ yajl_gen_config conf = { 1, " " };
+ return yajl_gen_alloc(&conf, allocFuncs);
+}
+#endif
+
#endif /* LIBXL_JSON_H */
diff -r cd47dde439e6 -r a1986ef30b7d tools/libxl/libxl_qmp.c
--- a/tools/libxl/libxl_qmp.c Sat Jan 14 19:04:48 2012 +0100
+++ b/tools/libxl/libxl_qmp.c Sun Jan 15 06:56:00 2012 +0100
@@ -453,15 +453,15 @@ static char *qmp_send_prepare(libxl__gc
qmp_callback_t callback, void *opaque,
qmp_request_context *context)
{
- yajl_gen_config conf = { 0, NULL };
const unsigned char *buf = NULL;
char *ret = NULL;
- unsigned int len = 0;
+ libxl_yajl_length len = 0;
yajl_gen_status s;
yajl_gen hand;
callback_id_pair *elm = NULL;
- hand = yajl_gen_alloc(&conf, NULL);
+ hand = libxl__yajl_gen_alloc(NULL);
+
if (!hand) {
return NULL;
}