Re: [PATCH 2/4] docs/html/: Annotations for two hypercalls

Ian Jackson
Tue, 29 Nov 2011 15:29:13 -0000

Ian Campbell writes ("Re: [Xen-devel] [PATCH 2/4] docs/html/: Annotations
for two hypercalls"):
> On Tue, 2011-11-29 at 15:01 +0000, Ian Jackson wrote:
> > This exercise revealed a couple of infelicities:
> >  * In the actual source code, do_mmu_update is defined to return an
int
> >    and do_set_trap_table a long.  However both functions return either
> >    -Efoo (on error) or 0 for success.
>
> Should that be fixed or would that do more harm than good?

I wasn''t sure whether I should go through all the hypercalls checking
and perhaps fixing up their return values.

> Acked-by: Ian Campbell <ian.campbell@citrix.com>

Thanks,
Ian.