Olaf Hering
2011-Oct-04 12:27 UTC
[Xen-devel] [PATCH] p2m: use correct p2m_type_t in clear_mmio_p2m_entry
# HG changeset patch
# User Olaf Hering <olaf@aepfle.de>
# Date 1317731210 -7200
# Node ID e77dd1bf489436d9f115be5d77327d1bbde1f1d2
# Parent 28556fcb81957a996b2c4b23a450cfefd95338b3
p2m: use correct p2m_type_t in clear_mmio_p2m_entry
clear_mmio_p2m_entry() should mark the gfn as invalid.
Use proper name instead of numerical value. The currently used value of
zero means p2m_ram_rw.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
diff -r 28556fcb8195 -r e77dd1bf4894 xen/arch/x86/mm/p2m.c
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -628,7 +628,7 @@ clear_mmio_p2m_entry(struct domain *d, u
return 0;
}
p2m_lock(p2m);
- rc = set_p2m_entry(p2m, gfn, _mfn(INVALID_MFN), 0, 0,
p2m->default_access);
+ rc = set_p2m_entry(p2m, gfn, _mfn(INVALID_MFN), 0, p2m_invalid,
p2m->default_access);
audit_p2m(p2m, 1);
p2m_unlock(p2m);
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Olaf Hering
2011-Oct-04 13:00 UTC
Re: [Xen-devel] [PATCH] p2m: use correct p2m_type_t in clear_mmio_p2m_entry
On Tue, Oct 04, Olaf Hering wrote:> p2m: use correct p2m_type_t in clear_mmio_p2m_entry > > clear_mmio_p2m_entry() should mark the gfn as invalid. > Use proper name instead of numerical value. The currently used value of > zero means p2m_ram_rw.This bug is also in xen-4.1-testing.hg Olaf _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Tim Deegan
2011-Oct-06 12:11 UTC
Re: [Xen-devel] [PATCH] p2m: use correct p2m_type_t in clear_mmio_p2m_entry
At 14:27 +0200 on 04 Oct (1317738439), Olaf Hering wrote:> # HG changeset patch > # User Olaf Hering <olaf@aepfle.de> > # Date 1317731210 -7200 > # Node ID e77dd1bf489436d9f115be5d77327d1bbde1f1d2 > # Parent 28556fcb81957a996b2c4b23a450cfefd95338b3 > p2m: use correct p2m_type_t in clear_mmio_p2m_entry > > clear_mmio_p2m_entry() should mark the gfn as invalid. > Use proper name instead of numerical value. The currently used value of > zero means p2m_ram_rw. > > Signed-off-by: Olaf Hering <olaf@aepfle.de>Applied, thanks, and backported to 4.1-testing Tim. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel