[Xen-devel] Re: [Qemu-devel] [PATCH RESEND v3] xen: implement unplug protocol in xen_platform

Alexander Graf
2011-07-27T13:26:41Z

On 07/27/2011 02:58 PM, Kevin Wolf wrote:
> Am 27.07.2011 14:44, schrieb Alexander Graf:
>> On 07/18/2011 06:07 PM, stefano.stabellini@eu.citrix.com wrote:
>>> From: Stefano Stabellini<stefano.stabellini@eu.citrix.com>
>>>
>>> The unplug protocol is necessary to support PV drivers in the
guest: the
>>> drivers expect to be able to "unplug" emulated disks and
nics before
>>> initializing the Xen PV interfaces.
>>> It is responsibility of the guest to make sure that the unplug is
done
>>> before the emulated devices or the PV interface start to be used.
>>>
>>> We use pci_for_each_device to walk the PCI bus, identify the
devices and
>>> disks that we want to disable and dynamically unplug them.
>>>
>>> Changes in v2:
>>>
>>> - use PCI_CLASS constants;
>>>
>>> - replace pci_unplug_device with qdev_unplug;
>>>
>>> - do not import hw/ide/internal.h in xen_platform.c;
>>>
>>>
>>> Changes in v3:
>>>
>>> - introduce piix3-ide-xen, that support hot-unplug;
>>>
>>> - move the unplug code to hw/ide/piix.c;
>>>
>>> - just call qdev_unplug from xen_platform.c to unplug the IDE
disks;
>>>
>>> Signed-off-by: Stefano
Stabellini<stefano.stabellini@eu.citrix.com>
>> Kevin, please ack.
> Trivial rebase of the version I already acked.

Thanks :). Applied to the xen-next branch.


Alex