Re: [Xen-devel] [PATCH] tools/libxl: testenum.c depends on libxl.h

Ian Campbell
2011-07-04T13:27:25Z

On Mon, 2011-07-04 at 14:18 +0100, Olaf Hering wrote:
> testenum.c may fail to compile if libxl.h dependencies are not yet met.

Ah yes, because the automated .*.d dependency tracking hasn''t kicked in
on a fresh build yet.

[...]
> Signed-off-by: Olaf Hering <olaf@aepfle.de>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

>
> Index: xen-unstable.hg-4.2.23655/tools/libxl/Makefile
> ==================================================================> ---
xen-unstable.hg-4.2.23655.orig/tools/libxl/Makefile
> +++ xen-unstable.hg-4.2.23655/tools/libxl/Makefile
> @@ -52,7 +52,7 @@ $(XL_OBJS): CFLAGS += $(CFLAGS_libxenctr
>  $(XL_OBJS): CFLAGS += $(CFLAGS_libxenlight)
>
>  testenum.o: CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenlight)
> -testenum.c: libxl.idl gentest.py
> +testenum.c: libxl.idl gentest.py libxl.h
>  	$(PYTHON) gentest.py libxl.idl testenum.c.new
>  	mv testenum.c.new testenum.c
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel