Xen devel - Apr 2011 - preempt_disable() imbalance in take_machine_down()? [linux-2.6.18-xen.hg]

Hi,

please excuse the lame question.

Looking at take_machine_down() and __xen_suspend() in 
"drivers/xen/core/machine_reboot.c", assuming "fast_suspend"
is false,
it seems that after the loop in take_machine_down() completes, 
preempt_enable() is never called. Is this intentional? If so, how/why 
does it work?

Thank you very much,
Laszlo Ersek

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

>>> On 05.04.11 at 15:59, Laszlo Ersek <lersek@redhat.com> wrote:
> Looking at take_machine_down() and __xen_suspend() in 
> "drivers/xen/core/machine_reboot.c", assuming
"fast_suspend" is false,
> it seems that after the loop in take_machine_down() completes, 
> preempt_enable() is never called. Is this intentional?
Probably not.
> If so, how/why does it work?
Because PREEMPT depends on !XEN in kernel/Kconfig.preempt.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel