Stephan Peijnik
2010-Oct-15 08:56 UTC
[Xen-devel] How to handle missing create.dtd in tools/python/xen/xm/xenapi_create.py?
Whilst writing my patch to replace the PyXML based XML validation code in xenapi_create.py I noticed that the old code did not handle a missing create.dtd file at all. My patch (see [0]) now issues a warning when create.dtd is missing, but I would like to know how we want to handle that case? Is issuing a Python warning enough or should we bail out with an error? create.dtd should usually not be missing in xen installations, but the Debian xen 4 package [1], in version 4.0.1-1, for example does not include the create.dtd file and thus the validation will not be carried out. Any other ideas on handling this? Is this a packaging bug or can create.dtd be omitted in xen installations? Regards, Stephan [0] http://xenbits.xensource.com/xen-unstable.hg?rev/b8cc53d22545 [1] http://packages.qa.debian.org/x/xen.html _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Stefano Stabellini
2010-Oct-15 14:43 UTC
Re: [Xen-devel] How to handle missing create.dtd in tools/python/xen/xm/xenapi_create.py?
On Fri, 15 Oct 2010, Stephan Peijnik wrote:> Whilst writing my patch to replace the PyXML based XML validation code > in xenapi_create.py I noticed that the old code did not handle a missing > create.dtd file at all. > > My patch (see [0]) now issues a warning when create.dtd is missing, but > I would like to know how we want to handle that case? > Is issuing a Python warning enough or should we bail out with an error? > create.dtd should usually not be missing in xen installations, but the > Debian xen 4 package [1], in version 4.0.1-1, for example does not > include the create.dtd file and thus the validation will not be carried > out. > > Any other ideas on handling this? Is this a packaging bug or can > create.dtd be omitted in xen installations? >I think that a missing DTD shouldn''t be considered an error by xend, even though a complete deb or rpm package should have it. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel