Hi, changesets 21674, 21772, and 21773 all insert definitions into a block restricting the use to Xen and its tools, while I believe these operations are all supposed to be used directly by guests. Am I missing something? Thanks, Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2010-Aug-31 07:40 UTC
Re: [Xen-devel] recent changes to xen/public/hvm/hvm_op.h
I assume it was considered a handy place for HVM-related control-plane operations, but which guests shouldn''t be executing themselves. K. On 31/08/2010 08:33, "Jan Beulich" <JBeulich@novell.com> wrote:> Hi, > > changesets 21674, 21772, and 21773 all insert definitions into a block > restricting the use to Xen and its tools, while I believe these operations > are all supposed to be used directly by guests. > > Am I missing something? > > Thanks, Jan > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Stefano Stabellini
2010-Aug-31 09:52 UTC
[Xen-devel] Re: recent changes to xen/public/hvm/hvm_op.h
On Tue, 31 Aug 2010, Jan Beulich wrote:> Hi, > > changesets 21674, 21772, and 21773 all insert definitions into a block > restricting the use to Xen and its tools, while I believe these operations > are all supposed to be used directly by guests. > > Am I missing something? >I think we made a mistake: I am sure HVMOP_pagetable_dying is executed directly by guests and probably HVMOP_get_time too. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Tim Deegan
2010-Aug-31 10:39 UTC
[Xen-devel] Re: recent changes to xen/public/hvm/hvm_op.h
At 10:52 +0100 on 31 Aug (1283251971), Stefano Stabellini wrote:> On Tue, 31 Aug 2010, Jan Beulich wrote: > > Hi, > > > > changesets 21674, 21772, and 21773 all insert definitions into a block > > restricting the use to Xen and its tools, while I believe these operations > > are all supposed to be used directly by guests. > > > > Am I missing something? > > > > I think we made a mistake: I am sure HVMOP_pagetable_dying is executed > directly by guests and probably HVMOP_get_time too.Yes, this is a porting error; all three of those are intended to be used by guests. Cheers, Tim. -- Tim Deegan <Tim.Deegan@citrix.com> Principal Software Engineer, XenServer Engineering Citrix Systems UK Ltd. (Company #02937203, SL9 0BG) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel