I got the below error when I do a ''make world'' in xen-testing.hg . The kernel is 2.6.31.14. gcc version is 4.5.0. It is working with gcc v4.3.0 Btw I thought the default kernel in xen-testing.hg is 2.6.32.x, but it is still 2.6.31.x. ............. LD drivers/xen/blktap/blktap.o LD drivers/xen/blktap/built-in.o CC drivers/xen/netback/netback.o /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c: In function ânet_rx_actionâ: /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:495:32: error: storage size of ârx_mclâ isnât constant /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:496:27: error: storage size of ârx_mmuâ isnât constant /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:497:32: error: storage size of âgrant_trans_opâ isnât constant /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:498:28: error: storage size of âgrant_copy_opâ isnât constant /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:500:13: error: storage size of ânotify_listâ isnât constant /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:501:30: error: storage size of âmetaâ isnât constant /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:529:2: warning:type defaults to âintâ in type name /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:529:2: warning:type defaults to âintâ in type name /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:529:2: error: size of unnamed array is negative /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:534:3: warning: type defaults to âintâ in type name /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:534:3: warning: type defaults to âintâ in type name /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:534:3: error: size of unnamed array is negative /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:548:3: warning: type defaults to âintâ in type name /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:548:3: warning: type defaults to âintâ in type name /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:548:3: error: size of unnamed array is negative /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:557:3: warning: type defaults to âintâ in type name /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:557:3: warning: type defaults to âintâ in type name /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:557:3: error: size of unnamed array is negative /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:569:2: warning: type defaults to âintâ in type name /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:569:2: warning: type defaults to âintâ in type name /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:569:2: error: size of unnamed array is negative /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:501:30: warning: unused variable âmetaâ /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:500:13: warning: unused variable ânotify_listâ /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:498:28: warning: unused variable âgrant_copy_opâ /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:497:32: warning: unused variable âgrant_trans_opâ /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:496:27: warning: unused variable ârx_mmuâ /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:495:32: warning: unused variable ârx_mclâ make[9]: *** [drivers/xen/netback/netback.o] Error 1 make[8]: *** [drivers/xen/netback] Error 2 make[7]: *** [drivers/xen] Error 2 make[6]: *** [drivers] Error 2 make[5]: *** [sub-make] Error 2 make[4]: *** [all] Error 2 Thanks, Masroor _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 08/18/2010 03:24 AM, Masroor Vettuparambil wrote:> I got the below error when I do a ''make world'' in xen-testing.hg . The kernel is 2.6.31.14. gcc version is 4.5.0. > It is working with gcc v4.3.0 > Btw I thought the default kernel in xen-testing.hg is 2.6.32.x, but it is still 2.6.31.x. > > ............. > > LD drivers/xen/blktap/blktap.o > LD drivers/xen/blktap/built-in.o > CC drivers/xen/netback/netback.o > /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c: In function ânet_rx_actionâ: > /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:495:32: error: storage size of ârx_mclâ isnât constantLooks like a gcc bug. Older gccs can compute __RING_SIZE() as a compile-time constant, but gcc 4.5.0 apparently isn''t doing that. It is, admittedly, a very complex expression, but gcc shouldn''t regress like this. I''m not sure how to work around it. J> /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:496:27: error: storage size of ârx_mmuâ isnât constant > /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:497:32: error: storage size of âgrant_trans_opâ isnât constant > /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:498:28: error: storage size of âgrant_copy_opâ isnât constant > /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:500:13: error: storage size of ânotify_listâ isnât constant > /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:501:30: error: storage size of âmetaâ isnât constant > /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:529:2: warning:type defaults to âintâ in type name > /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:529:2: warning:type defaults to âintâ in type name > /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:529:2: error: size of unnamed array is negative > /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:534:3: warning: type defaults to âintâ in type name > /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:534:3: warning: type defaults to âintâ in type name > /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:534:3: error: size of unnamed array is negative > /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:548:3: warning: type defaults to âintâ in type name > /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:548:3: warning: type defaults to âintâ in type name > /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:548:3: error: size of unnamed array is negative > /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:557:3: warning: type defaults to âintâ in type name > /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:557:3: warning: type defaults to âintâ in type name > /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:557:3: error: size of unnamed array is negative > /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:569:2: warning: type defaults to âintâ in type name > /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:569:2: warning: type defaults to âintâ in type name > /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:569:2: error: size of unnamed array is negative > /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:501:30: warning: unused variable âmetaâ > /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:500:13: warning: unused variable ânotify_listâ > /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:498:28: warning: unused variable âgrant_copy_opâ > /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:497:32: warning: unused variable âgrant_trans_opâ > /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:496:27: warning: unused variable ârx_mmuâ > /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:495:32: warning: unused variable ârx_mclâ > make[9]: *** [drivers/xen/netback/netback.o] Error 1 > make[8]: *** [drivers/xen/netback] Error 2 > make[7]: *** [drivers/xen] Error 2 > make[6]: *** [drivers] Error 2 > make[5]: *** [sub-make] Error 2 > make[4]: *** [all] Error 2 > > > Thanks, > Masroor > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Wed, 18 Aug 2010, Jeremy Fitzhardinge wrote:> On 08/18/2010 03:24 AM, Masroor Vettuparambil wrote: >> I got the below error when I do a ''make world'' in xen-testing.hg . The kernel is 2.6.31.14. gcc version is 4.5.0. >> It is working with gcc v4.3.0 >> Btw I thought the default kernel in xen-testing.hg is 2.6.32.x, but it is still 2.6.31.x. >> >> ............. >> >> LD drivers/xen/blktap/blktap.o >> LD drivers/xen/blktap/built-in.o >> CC drivers/xen/netback/netback.o >> /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c: In function ânet_rx_actionâ: >> /home/xen/xen-4.0-testing.hg/linux-2.6-pvops.git/drivers/xen/netback/netback.c:495:32: error: storage size of ârx_mclâ isnât constant > > Looks like a gcc bug. Older gccs can compute __RING_SIZE() as a > compile-time constant, but gcc 4.5.0 apparently isn''t doing that. It > is, admittedly, a very complex expression, but gcc shouldn''t regress > like this. I''m not sure how to work around it.One option is to use __CONST_RING_SIZE instead of __RING_SIZE if that is available. I had a similar problem compiling xen with gcc 4.5 where this worked. Michael Young _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 18/08/2010 20:44, "M A Young" <m.a.young@durham.ac.uk> wrote:> On Wed, 18 Aug 2010, Jeremy Fitzhardinge wrote: >> Looks like a gcc bug. Older gccs can compute __RING_SIZE() as a >> compile-time constant, but gcc 4.5.0 apparently isn''t doing that. It >> is, admittedly, a very complex expression, but gcc shouldn''t regress >> like this. I''m not sure how to work around it. > > One option is to use __CONST_RING_SIZE instead of __RING_SIZE if that is > available. I had a similar problem compiling xen with gcc 4.5 where this > worked.Yes that is exactly why Jan Beulich introduced __CONST_RING_SIZE, in xen-unstable:20975. Should be a simple patch to pv_ops netfront/back drivers to make use of it. -- Keir> Michael Young_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 08/18/2010 12:55 PM, Keir Fraser wrote:> On 18/08/2010 20:44, "M A Young" <m.a.young@durham.ac.uk> wrote: > >> On Wed, 18 Aug 2010, Jeremy Fitzhardinge wrote: >>> Looks like a gcc bug. Older gccs can compute __RING_SIZE() as a >>> compile-time constant, but gcc 4.5.0 apparently isn''t doing that. It >>> is, admittedly, a very complex expression, but gcc shouldn''t regress >>> like this. I''m not sure how to work around it. >> One option is to use __CONST_RING_SIZE instead of __RING_SIZE if that is >> available. I had a similar problem compiling xen with gcc 4.5 where this >> worked. > Yes that is exactly why Jan Beulich introduced __CONST_RING_SIZE, in > xen-unstable:20975. Should be a simple patch to pv_ops netfront/back drivers > to make use of it.Ah, OK. I''ll bring it across and sprinkle it around. J _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel