Re: [Xen-devel] [PATCH]: Implement xl dump-core

Gianni Tedesco
Wed, 21 Jul 2010 15:59:09 -0000

On Wed, 2010-07-21 at 16:45 +0100, Ian Jackson wrote:
> Gianni Tedesco writes ("[Xen-devel] [PATCH]: Implement xl
dump-core"):
> > +int libxl_domain_core_dump(struct libxl_ctx *ctx, uint32_t domid,
const char *filename)
>
> Not that there''s anything wrong with your patch, but why do these
> calls (by which I mean to include the libxc call) take a filename
> rather than an fd ?

It''s a mystery to me too. Although in the core dump case there is a
separate call, xc_domain_dumpcore_via_callback, which takes a callback
function through which such functionality may be implemented.

Gianni