Rose, Gregory V
2010-Jul-14 20:59 UTC
[Xen-devel] [xen/stable-2.6.32.x PATCH 0/5] SR-IOV: Backport VF MAC and VLAN configuration to 2.6.32.x
This series of patches is a back port of patches originally inluded in the Linux 2.6.34 kernel to the xen/2.6.32.x branch. Authors of the original patches are CC''d. The purpose of the patches is to allow configuration of SR-IOV virtual function MAC address and VLAN ID via the physical function driver in those drivers that support SR-IOV and export the required netdev ops functions. The commits from the original patches in the Linux 2.6.34 kernel git logs are: commit fb8a0d9d1bfd1e4355f307e86a6da7209eefd5f3 commit b280da8d54b8d82b52f368a8703b7ada6c1744d5 commit 95c26df829ba4a25f40595cadb4c9433883cbe28 commit ebc08a6f47ee76ecad8e9f26c26e6ec9b46ca659 commit c02db8c6290bb992442fec1407643c94cc414375 You can test that the patches are working right by downloading the Intel ixgbe driver Revision 2.0.84.9 from sourceforge. http://sourceforge.net/projects/e1000/ Signed-off-by: Greg Rose <gregory.v.rose@intel.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Rose, Gregory V
2010-Jul-14 21:47 UTC
RE: [Xen-devel] [xen/stable-2.6.32.x PATCH 0/5] SR-IOV: Backport VF MAC and VLAN configuration to 2.6.32.x
>-----Original Message----- >From: xen-devel-bounces@lists.xensource.com [mailto:xen-devel- >bounces@lists.xensource.com] On Behalf Of Rose, Gregory V >Sent: Wednesday, July 14, 2010 2:00 PM >To: ''xen-devel@lists.xensource.com'' >Subject: [Xen-devel] [xen/stable-2.6.32.x PATCH 0/5] SR-IOV: Backport VF >MAC and VLAN configuration to 2.6.32.x > >This series of patches is a back port of patches originally inluded >in the Linux 2.6.34 kernel to the xen/2.6.32.x branch. Authors of >the original patches are CC''d. > >The purpose of the patches is to allow configuration of SR-IOV virtual >function MAC address and VLAN ID via the physical function driver in >those drivers that support SR-IOV and export the required netdev ops >functions. > >The commits from the original patches in the Linux 2.6.34 kernel git >logs are: > >commit fb8a0d9d1bfd1e4355f307e86a6da7209eefd5f3 >commit b280da8d54b8d82b52f368a8703b7ada6c1744d5 >commit 95c26df829ba4a25f40595cadb4c9433883cbe28 >commit ebc08a6f47ee76ecad8e9f26c26e6ec9b46ca659 >commit c02db8c6290bb992442fec1407643c94cc414375 > >You can test that the patches are working right by downloading the Intel >ixgbe driver Revision 2.0.84.9 from sourceforge. > >http://sourceforge.net/projects/e1000/ > >Signed-off-by: Greg Rose <gregory.v.rose@intel.com> >I almost forgot something. Because the kernel in which these patches was accepted was 2.6.34 the sourceforge driver I mention above won''t include the net netdev ops unless you apply this short patch to it. --- ixgbe-2.0.84.9/src/kcompat.h 2010-06-24 14:05:25.000000000 -0700 +++ ixgbe-2.0.84.9-iplink/src/kcompat.h 2010-07-08 15:06:41.000000000 -0700 @@ -2055,6 +2055,7 @@ extern u16 _kc_skb_tx_hash(struct net_de #ifndef HAVE_TRANS_START_IN_QUEUE #define HAVE_TRANS_START_IN_QUEUE #endif +#define HAVE_IPLINK_VF_CONFIG #endif /* < 2.6.31 */ /*****************************************************************************/ This allows the driver to include the necessary netdev ops on a 2.6.32 kernel. - Greg _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jeremy Fitzhardinge
2010-Jul-15 17:04 UTC
Re: [Xen-devel] [xen/stable-2.6.32.x PATCH 0/5] SR-IOV: Backport VF MAC and VLAN configuration to 2.6.32.x
On 07/14/2010 01:59 PM, Rose, Gregory V wrote:> This series of patches is a back port of patches originally inluded > in the Linux 2.6.34 kernel to the xen/2.6.32.x branch. Authors of > the original patches are CC''d. > > The purpose of the patches is to allow configuration of SR-IOV virtual > function MAC address and VLAN ID via the physical function driver in > those drivers that support SR-IOV and export the required netdev ops > functions. > > The commits from the original patches in the Linux 2.6.34 kernel git > logs are: > > commit fb8a0d9d1bfd1e4355f307e86a6da7209eefd5f3 > commit b280da8d54b8d82b52f368a8703b7ada6c1744d5 > commit 95c26df829ba4a25f40595cadb4c9433883cbe28 > commit ebc08a6f47ee76ecad8e9f26c26e6ec9b46ca659 > commit c02db8c6290bb992442fec1407643c94cc414375 >Do you have a git tree I can pull these from? Thanks, J _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Rose, Gregory V
2010-Jul-15 17:13 UTC
RE: [Xen-devel] [xen/stable-2.6.32.x PATCH 0/5] SR-IOV: Backport VF MAC and VLAN configuration to 2.6.32.x
>-----Original Message----- >From: Jeremy Fitzhardinge [mailto:jeremy@goop.org] >Sent: Thursday, July 15, 2010 10:05 AM >To: Rose, Gregory V >Cc: ''xen-devel@lists.xensource.com'' >Subject: Re: [Xen-devel] [xen/stable-2.6.32.x PATCH 0/5] SR-IOV: >Backport VF MAC and VLAN configuration to 2.6.32.x > >On 07/14/2010 01:59 PM, Rose, Gregory V wrote: >> This series of patches is a back port of patches originally inluded >> in the Linux 2.6.34 kernel to the xen/2.6.32.x branch. Authors of >> the original patches are CC''d. >> >> The purpose of the patches is to allow configuration of SR-IOV virtual >> function MAC address and VLAN ID via the physical function driver in >> those drivers that support SR-IOV and export the required netdev ops >> functions. >> >> The commits from the original patches in the Linux 2.6.34 kernel git >> logs are: >> >> commit fb8a0d9d1bfd1e4355f307e86a6da7209eefd5f3 >> commit b280da8d54b8d82b52f368a8703b7ada6c1744d5 >> commit 95c26df829ba4a25f40595cadb4c9433883cbe28 >> commit ebc08a6f47ee76ecad8e9f26c26e6ec9b46ca659 >> commit c02db8c6290bb992442fec1407643c94cc414375 >> >>Do you have a git tree I can pull these from? >They''re in Linus'' git tree at kernel.org. git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6 - Greg _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jeremy Fitzhardinge
2010-Jul-15 17:31 UTC
Re: [Xen-devel] [xen/stable-2.6.32.x PATCH 0/5] SR-IOV: Backport VF MAC and VLAN configuration to 2.6.32.x
On 07/15/2010 10:13 AM, Rose, Gregory V wrote:>> -----Original Message----- >> From: Jeremy Fitzhardinge [mailto:jeremy@goop.org] >> Sent: Thursday, July 15, 2010 10:05 AM >> To: Rose, Gregory V >> Cc: ''xen-devel@lists.xensource.com'' >> Subject: Re: [Xen-devel] [xen/stable-2.6.32.x PATCH 0/5] SR-IOV: >> Backport VF MAC and VLAN configuration to 2.6.32.x >> >> On 07/14/2010 01:59 PM, Rose, Gregory V wrote: >> >>> This series of patches is a back port of patches originally inluded >>> in the Linux 2.6.34 kernel to the xen/2.6.32.x branch. Authors of >>> the original patches are CC''d. >>> >>> The purpose of the patches is to allow configuration of SR-IOV virtual >>> function MAC address and VLAN ID via the physical function driver in >>> those drivers that support SR-IOV and export the required netdev ops >>> functions. >>> >>> The commits from the original patches in the Linux 2.6.34 kernel git >>> logs are: >>> >>> commit fb8a0d9d1bfd1e4355f307e86a6da7209eefd5f3 >>> commit b280da8d54b8d82b52f368a8703b7ada6c1744d5 >>> commit 95c26df829ba4a25f40595cadb4c9433883cbe28 >>> commit ebc08a6f47ee76ecad8e9f26c26e6ec9b46ca659 >>> commit c02db8c6290bb992442fec1407643c94cc414375 >>> >>> >> > >> Do you have a git tree I can pull these from? >> >> > They''re in Linus'' git tree at kernel.org. > > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6 >I meant the backported versions. Or do they just rebase with no effort? J _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Rose, Gregory V
2010-Jul-15 17:34 UTC
RE: [Xen-devel] [xen/stable-2.6.32.x PATCH 0/5] SR-IOV: Backport VF MAC and VLAN configuration to 2.6.32.x
>-----Original Message----- >From: Jeremy Fitzhardinge [mailto:jeremy@goop.org] >Sent: Thursday, July 15, 2010 10:31 AM >To: Rose, Gregory V >Cc: ''xen-devel@lists.xensource.com'' >Subject: Re: [Xen-devel] [xen/stable-2.6.32.x PATCH 0/5] SR-IOV: >Backport VF MAC and VLAN configuration to 2.6.32.x > >On 07/15/2010 10:13 AM, Rose, Gregory V wrote: >>> -----Original Message----- >>> From: Jeremy Fitzhardinge [mailto:jeremy@goop.org] >>> Sent: Thursday, July 15, 2010 10:05 AM >>> To: Rose, Gregory V >>> Cc: ''xen-devel@lists.xensource.com'' >>> Subject: Re: [Xen-devel] [xen/stable-2.6.32.x PATCH 0/5] SR-IOV: >>> Backport VF MAC and VLAN configuration to 2.6.32.x >>> >>> On 07/14/2010 01:59 PM, Rose, Gregory V wrote: >>> >>>> This series of patches is a back port of patches originally inluded >>>> in the Linux 2.6.34 kernel to the xen/2.6.32.x branch. Authors of >>>> the original patches are CC''d. >>>> >>>> The purpose of the patches is to allow configuration of SR-IOV >virtual >>>> function MAC address and VLAN ID via the physical function driver in >>>> those drivers that support SR-IOV and export the required netdev ops >>>> functions. >>>> >>>> The commits from the original patches in the Linux 2.6.34 kernel git >>>> logs are: >>>> >>>> commit fb8a0d9d1bfd1e4355f307e86a6da7209eefd5f3 >>>> commit b280da8d54b8d82b52f368a8703b7ada6c1744d5 >>>> commit 95c26df829ba4a25f40595cadb4c9433883cbe28 >>>> commit ebc08a6f47ee76ecad8e9f26c26e6ec9b46ca659 >>>> commit c02db8c6290bb992442fec1407643c94cc414375 >>>> >>>> >>> >> >>> Do you have a git tree I can pull these from? >>> >>> >> They''re in Linus'' git tree at kernel.org. >> >> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6 >> > >I meant the backported versions. Or do they just rebase with no effort?Oh, excuse me, I misunderstood. The patches I posted should apply cleanly to your tree on the xen/stable-2.6.32.x branch as of yesterday. If they don''t I can rebase them and re-send. - Greg _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jeremy Fitzhardinge
2010-Jul-15 21:12 UTC
Re: [Xen-devel] [xen/stable-2.6.32.x PATCH 0/5] SR-IOV: Backport VF MAC and VLAN configuration to 2.6.32.x
On 07/15/2010 10:34 AM, Rose, Gregory V wrote:>> -----Original Message----- >> From: Jeremy Fitzhardinge [mailto:jeremy@goop.org] >> Sent: Thursday, July 15, 2010 10:31 AM >> To: Rose, Gregory V >> Cc: ''xen-devel@lists.xensource.com'' >> Subject: Re: [Xen-devel] [xen/stable-2.6.32.x PATCH 0/5] SR-IOV: >> Backport VF MAC and VLAN configuration to 2.6.32.x >> >> On 07/15/2010 10:13 AM, Rose, Gregory V wrote: >> >>>> -----Original Message----- >>>> From: Jeremy Fitzhardinge [mailto:jeremy@goop.org] >>>> Sent: Thursday, July 15, 2010 10:05 AM >>>> To: Rose, Gregory V >>>> Cc: ''xen-devel@lists.xensource.com'' >>>> Subject: Re: [Xen-devel] [xen/stable-2.6.32.x PATCH 0/5] SR-IOV: >>>> Backport VF MAC and VLAN configuration to 2.6.32.x >>>> >>>> On 07/14/2010 01:59 PM, Rose, Gregory V wrote: >>>> >>>> >>>>> This series of patches is a back port of patches originally inluded >>>>> in the Linux 2.6.34 kernel to the xen/2.6.32.x branch. Authors of >>>>> the original patches are CC''d. >>>>> >>>>> The purpose of the patches is to allow configuration of SR-IOV >>>>> >> virtual >> >>>>> function MAC address and VLAN ID via the physical function driver in >>>>> those drivers that support SR-IOV and export the required netdev ops >>>>> functions. >>>>> >>>>> The commits from the original patches in the Linux 2.6.34 kernel git >>>>> logs are: >>>>> >>>>> commit fb8a0d9d1bfd1e4355f307e86a6da7209eefd5f3 >>>>> commit b280da8d54b8d82b52f368a8703b7ada6c1744d5 >>>>> commit 95c26df829ba4a25f40595cadb4c9433883cbe28 >>>>> commit ebc08a6f47ee76ecad8e9f26c26e6ec9b46ca659 >>>>> commit c02db8c6290bb992442fec1407643c94cc414375 >>>>> >>>>> >>>>> >>>> >>> >>>> Do you have a git tree I can pull these from? >>>> >>>> >>>> >>> They''re in Linus'' git tree at kernel.org. >>> >>> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6 >>> >>> >> I meant the backported versions. Or do they just rebase with no effort? >> > Oh, excuse me, I misunderstood. > > The patches I posted should apply cleanly to your tree on the xen/stable-2.6.32.x branch as of yesterday. If they don''t I can rebase them and re-send. >I just cherry-picked the original patches onto v2.6.32 and pushed the results as the "sr-iov" branch. Please check it and I''ll merge it in when you give the all-clear. Thanks, J _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Rose, Gregory V
2010-Jul-15 21:32 UTC
RE: [Xen-devel] [xen/stable-2.6.32.x PATCH 0/5] SR-IOV: Backport VF MAC and VLAN configuration to 2.6.32.x
>-----Original Message----- >From: Jeremy Fitzhardinge [mailto:jeremy@goop.org] >Sent: Thursday, July 15, 2010 2:12 PM >To: Rose, Gregory V >Cc: ''xen-devel@lists.xensource.com'' >Subject: Re: [Xen-devel] [xen/stable-2.6.32.x PATCH 0/5] SR-IOV: >Backport VF MAC and VLAN configuration to 2.6.32.x > > >I just cherry-picked the original patches onto v2.6.32 and pushed the >results as the "sr-iov" branch. Please check it and I''ll merge it in >when you give the all-clear.Will do. - Greg _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Rose, Gregory V
2010-Jul-16 19:19 UTC
RE: [Xen-devel] [xen/stable-2.6.32.x PATCH 0/5] SR-IOV: Backport VF MAC and VLAN configuration to 2.6.32.x
>-----Original Message----- >From: Jeremy Fitzhardinge [mailto:jeremy@goop.org] >Sent: Thursday, July 15, 2010 2:12 PM >To: Rose, Gregory V >Cc: ''xen-devel@lists.xensource.com'' >Subject: Re: [Xen-devel] [xen/stable-2.6.32.x PATCH 0/5] SR-IOV: >Backport VF MAC and VLAN configuration to 2.6.32.x > > >I just cherry-picked the original patches onto v2.6.32 and pushed the >results as the "sr-iov" branch. Please check it and I''ll merge it in >when you give the all-clear. > >Thanks, > JI seem to have run into a problem. I''ve built the kernel but it won''t boot. At all. On my serial console I get the output below and then the system hangs. Takes a power cycle to bring it back. The base distro is SLES 11. Pretty odd, I''m able to boot all the recent upstream kernels just fine. I''ll try building without Xen enabled. It''s not necessary to test the patches. - Greg Booting ''Xen 4.0 2.6.32-xen'' root (hd0,1) Filesystem type is ext2fs, partition type 0x83 kernel /boot/xen-4.0.1.gz [Multiboot-elf, <0x100000:0x164000:0x143000>, shtab=0x3a7078, entry=0x100000 ] module /boot/bzImage-2.6.32-5-default root=/dev/disk/by-id/ata-Maxtor_7Y250M0_Y 62EWV6E-part2 resume=/dev/disk/by-id/ata-Maxtor_7Y250M0_Y62EWV6E-part1 splash=s ilent showopts vga=0x31a console=tty0 console=ttyS0,115200 max_loop=128 [Multiboot-module @ 0x3a8000, 0x278860 bytes] module /boot/initrd-2.6.32-5-default.img [Multiboot-module @ 0x621000, 0x23b9400 bytes] _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Rose, Gregory V
2010-Jul-16 20:07 UTC
RE: [Xen-devel] [xen/stable-2.6.32.x PATCH 0/5] SR-IOV: Backport VF MAC and VLAN configuration to 2.6.32.x
>-----Original Message----- >From: xen-devel-bounces@lists.xensource.com [mailto:xen-devel- >bounces@lists.xensource.com] On Behalf Of Rose, Gregory V >Sent: Friday, July 16, 2010 12:20 PM >To: Jeremy Fitzhardinge >Cc: ''xen-devel@lists.xensource.com'' >Subject: RE: [Xen-devel] [xen/stable-2.6.32.x PATCH 0/5] SR-IOV: >Backport VF MAC and VLAN configuration to 2.6.32.x > >>-----Original Message----- >>From: Jeremy Fitzhardinge [mailto:jeremy@goop.org] >>Sent: Thursday, July 15, 2010 2:12 PM >>To: Rose, Gregory V >>Cc: ''xen-devel@lists.xensource.com'' >>Subject: Re: [Xen-devel] [xen/stable-2.6.32.x PATCH 0/5] SR-IOV: >>Backport VF MAC and VLAN configuration to 2.6.32.x >> >> >>I just cherry-picked the original patches onto v2.6.32 and pushed the >>results as the "sr-iov" branch. Please check it and I''ll merge it in >>when you give the all-clear. >> >>Thanks, >> J > >I seem to have run into a problem. I''ve built the kernel but it won''t >boot. At all. > >On my serial console I get the output below and then the system hangs. >Takes a power cycle to bring it back. > >The base distro is SLES 11. > >Pretty odd, I''m able to boot all the recent upstream kernels just fine. >I''ll try building without Xen enabled. It''s not necessary to test the >patches. > >- Greg > >Booting ''Xen 4.0 2.6.32-xen'' > >root (hd0,1) > Filesystem type is ext2fs, partition type 0x83 >kernel /boot/xen-4.0.1.gz > [Multiboot-elf, <0x100000:0x164000:0x143000>, shtab=0x3a7078, >entry=0x100000 >] >module /boot/bzImage-2.6.32-5-default root=/dev/disk/by-id/ata- >Maxtor_7Y250M0_Y >62EWV6E-part2 resume=/dev/disk/by-id/ata-Maxtor_7Y250M0_Y62EWV6E-part1 >splash=s >ilent showopts vga=0x31a console=tty0 console=ttyS0,115200 max_loop=128 > [Multiboot-module @ 0x3a8000, 0x278860 bytes] >module /boot/initrd-2.6.32-5-default.img > [Multiboot-module @ 0x621000, 0x23b9400 bytes]Found the problem. Had to turn off interrupt remapping support in my BIOS. - Greg _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Rose, Gregory V
2010-Jul-16 20:57 UTC
RE: [Xen-devel] [xen/stable-2.6.32.x PATCH 0/5] SR-IOV: Backport VF MAC and VLAN configuration to 2.6.32.x
>-----Original Message----- >From: Jeremy Fitzhardinge [mailto:jeremy@goop.org] >Sent: Thursday, July 15, 2010 2:12 PM >To: Rose, Gregory V >Cc: ''xen-devel@lists.xensource.com'' >Subject: Re: [Xen-devel] [xen/stable-2.6.32.x PATCH 0/5] SR-IOV: >Backport VF MAC and VLAN configuration to 2.6.32.x >> >I just cherry-picked the original patches onto v2.6.32 and pushed the >results as the "sr-iov" branch. Please check it and I''ll merge it in >when you give the all-clear. > >Thanks, > JLooks good Jeremy. I used the latest iproute2 package ip link command to set the VF MAC addresses on two 82599EB 10Gig ports named eth3 and eth4: /usr/sbin/ip link set eth3 vf 0 mac 00:01:02:BA:BB:00 /usr/sbin/ip link set eth3 vf 1 mac 00:01:02:BA:BB:01 /usr/sbin/ip link set eth3 vf 2 mac 00:01:02:BA:BB:02 /usr/sbin/ip link set eth3 vf 3 mac 00:01:02:BA:BB:03 /usr/sbin/ip link set eth4 vf 0 mac 00:01:02:BA:BB:40 /usr/sbin/ip link set eth4 vf 1 mac 00:01:02:BA:BB:41 /usr/sbin/ip link set eth4 vf 2 mac 00:01:02:BA:BB:42 /usr/sbin/ip link set eth4 vf 3 mac 00:01:02:BA:BB:43 I can then show the output with the ip link show command: ip link show eth3 6: eth3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP qlen 1000 link/ether 00:1b:21:3c:a3:1c brd ff:ff:ff:ff:ff:ff vf 0 MAC 00:01:02:ba:bb:00 vf 1 MAC 00:01:02:ba:bb:01 vf 2 MAC 00:01:02:ba:bb:02 vf 3 MAC 00:01:02:ba:bb:03 ip link show eth4 7: eth4: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP qlen 1000 link/ether 00:1b:21:3c:a3:1d brd ff:ff:ff:ff:ff:ff vf 0 MAC 00:01:02:ba:bb:40 vf 1 MAC 00:01:02:ba:bb:41 vf 2 MAC 00:01:02:ba:bb:42 vf 3 MAC 00:01:02:ba:bb:43 Load the ixgbevf driver in a guest it uses the correct MAC address and passes traffic. I''ll do some more thorough testing but so far looking good. Please let me know when it''s merged to your xen/stable-2.6.32.x branch and I''ll keep working from that tree. I have other work on deck for further VSI and EVB configuration work in the kernel that I''ll want to port into your tree after I get it accepted upstream. Thanks, - Greg _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel