Re: [Xen-devel] [PATCH] reduce ''d'' debug key''s global impact

Keir Fraser
2010-05-05T09:34:17Z

On 05/05/2010 10:30, "Jan Beulich" <JBeulich@novell.com> wrote:

>>>> Keir Fraser <keir.fraser@eu.citrix.com> 05.05.10 11:05
>>>
>> I''m not against the ''alt-key'' scheme in your
''0''-key handler patch. Perhaps
>> you could extend the alt-key principle to the ''d''
key, and leave the
>> existing serialised dump mechanism when in non-alt mode? That would be
more
>> acceptable to me.
>
> I had considered this, but then decided to do the change unconditional
> here, as other than for ''0'', where using tasklets comes
with a certain risk,
> ''d'' with the change isn''t any more dangerous
than without. But if making
> this optional is going to help acceptance, I''ll modify it
accordingly.

The potential for interleaved output is an issue for me. I''ll let it
slide
if it''s only in the alt-key scheme.

 -- Keir