[Xen-devel] [PATCH] No cpu_add_remove_lock in do_boot_cpu

Jiang, Yunhong
Mon, 22 Mar 2010 06:23:23 -0000

No cpu_add_remove_lock in do_boot_cpu.

The do_boot_cpu() will be called when system booting or CPU online. When system
booting, we don''t need hold this lock. When system online, the lock is
held already by cpu_up.

Signed-off-by: Jiang, Yunhong <yunhong.jiang@intel.com>

diff -r c1f272c3a441 xen/arch/x86/smpboot.c
--- a/xen/arch/x86/smpboot.c	Mon Mar 15 17:08:29 2010 +0000
+++ b/xen/arch/x86/smpboot.c	Thu Mar 18 15:46:12 2010 +0800
@@ -984,10 +984,8 @@ static int __devinit do_boot_cpu(int api
 		cpucount--;

 		/* Mark the CPU as non-present */
-		spin_lock(&cpu_add_remove_lock);
 		x86_cpu_to_apicid[cpu] = BAD_APICID;
 		cpu_clear(cpu, cpu_present_map);
-		spin_unlock(&cpu_add_remove_lock);
 	} else {
 	}





_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com