[Xen-devel] Re: [PATCH][ioemu] Ignore the first watch fire in xenstore_process_dm_command_event()

Keir Fraser
Tue, 16 Jun 2009 17:27:02 -0000

On 16/06/2009 18:04, "Cui, Dexuan" <dexuan.cui@intel.com> wrote:

> A straightforward thought is: we can ignore the first watch fire. Please
see
> the below patch.
> However I''m not sure if this is the best fix. And for the other
watches(like
> "logdirty", "hdc") set in
xenstore_parse_domain_config(), I think we should
> also double check them even if no actual bug has been observed yet.
>
> Please comment.

Can you not treat the watch firing as an indication of maybe-changed, and
decide what to do based on current values you read from xenstore from within
the watch handler?

 -- Keir