Xen devel - Jun 2009 - Attempt to build xen-unstable on F11 ( gcc version 4.4.0 )

The failure bellow doesn''t happen with gcc 4.3.3 ( Ubuntu 9.04 Server)
. . . . . . . . . . . .
gcc  -O2 -fomit-frame-pointer -m64 -fno-strict-aliasing -std=gnu99 -Wall
-Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement 
-D__XEN_TOOLS__ -MMD -MF .vhd-util-check.o.d  -D_LARGEFILE_SOURCE
-D_LARGEFILE64_SOURCE  -Werror -Wno-unused -I../../include -D_GNU_SOURCE -fPIC
-g -Wp,-MD,.vhd-util-check.o.d -c -o vhd-util-check.o vhd-util-check.c
cc1: warnings being treated as errors
vhd-util-check.c: In function ‘vhd_util_check_vhd’:
vhd-util-check.c:809: error: ‘footer.data_offset’ may be used uninitialized in
this function
vhd-util-check.c:809: error: ‘footer.type’ may be used uninitialized in this
function
make[7]: *** [vhd-util-check.o] Error 1
make[7]: Leaving directory
`/usr/src/xen-unstable.hg/tools/blktap2/vhd/lib''
make[6]: *** [subdir-all-lib] Error 2
make[6]: Leaving directory `/usr/src/xen-unstable.hg/tools/blktap2/vhd''
make[5]: *** [subdirs-all] Error 2
make[5]: Leaving directory `/usr/src/xen-unstable.hg/tools/blktap2/vhd''
make[4]: *** [subdir-install-vhd] Error 2
make[4]: Leaving directory `/usr/src/xen-unstable.hg/tools/blktap2''
make[3]: *** [subdirs-install] Error 2
make[3]: Leaving directory `/usr/src/xen-unstable.hg/tools/blktap2''
make[2]: *** [subdir-install-blktap2] Error 2
make[2]: Leaving directory `/usr/src/xen-unstable.hg/tools''
make[1]: *** [subdirs-install] Error 2
make[1]: Leaving directory `/usr/src/xen-unstable.hg/tools''
make: *** [install-tools] Error 2

Boris.



      

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Wed, Jun 24, 2009 at 6:57 PM, Boris Derzhavets<bderzhavets@yahoo.com>
wrote:
> The failure bellow doesn''t happen with gcc 4.3.3 ( Ubuntu 9.04
Server)
> . . . . . . . . . . . .
> gcc  -O2 -fomit-frame-pointer -m64 -fno-strict-aliasing -std=gnu99 -Wall
> -Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement
> -D__XEN_TOOLS__ -MMD -MF .vhd-util-check.o.d  -D_LARGEFILE_SOURCE
> -D_LARGEFILE64_SOURCE  -Werror -Wno-unused -I../../include -D_GNU_SOURCE
> -fPIC -g -Wp,-MD,.vhd-util-check.o.d -c -o vhd-util-check.o
vhd-util-check.c
> cc1: warnings being treated as errors
> vhd-util-check.c: In function ‘vhd_util_check_vhd’:
> vhd-util-check.c:809: error: ‘footer.data_offset’ may be used uninitialized
> in this function
> vhd-util-check.c:809: error: ‘footer.type’ may be used uninitialized in
this
> function
I had a quick fix for this problem, with following patch. Perhaps that
is not the best way, but at least you can compile blktap2 with it.

For other compilation problems with blktap2, you can pick up the
patches I just post to the list.

Thanks,
J


diff -r 442fb5f1e0a2 tools/blktap2/vhd/lib/vhd-util-check.c
--- a/tools/blktap2/vhd/lib/vhd-util-check.c	Tue Jun 23 17:32:07 2009 +0100
+++ b/tools/blktap2/vhd/lib/vhd-util-check.c	Wed Jun 24 19:04:17 2009 +0900
@@ -808,6 +808,9 @@
 	struct stat stats;
 	vhd_footer_t footer;

+	footer.data_offset = 0;
+	footer.type = 0;
+
 	fd = -1;
 	memset(&vhd, 0, sizeof(vhd));

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

One more fix to build tools required :-

./tools/blktap2/drivers/lock.c
line 253

 -  if (!dptr & errno)    {
 +  if ((!dptr) & errno) {

Boris

--- On Wed, 6/24/09, Jun Koi <junkoi2004@gmail.com> wrote:

From: Jun Koi <junkoi2004@gmail.com>
Subject: Re: [Xen-devel] Attempt to build xen-unstable on F11 ( gcc version 
4.4.0 )
To: "Boris Derzhavets" <bderzhavets@yahoo.com>
Cc: "xen-devel@lists.xensource.com"
<xen-devel@lists.xensource.com>, "Ian Campbell"
<Ian.Campbell@citrix.com>
Date: Wednesday, June 24, 2009, 6:07 AM

On Wed, Jun 24, 2009 at 6:57 PM, Boris Derzhavets<bderzhavets@yahoo.com>
wrote:
> The failure bellow doesn''t happen with gcc 4.3.3 ( Ubuntu 9.04
Server)
> . . . . . . . . . . . .
> gcc  -O2 -fomit-frame-pointer -m64 -fno-strict-aliasing -std=gnu99 -Wall
> -Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement
> -D__XEN_TOOLS__ -MMD -MF .vhd-util-check.o.d  -D_LARGEFILE_SOURCE
> -D_LARGEFILE64_SOURCE  -Werror -Wno-unused -I../../include -D_GNU_SOURCE
> -fPIC -g -Wp,-MD,.vhd-util-check.o.d -c -o vhd-util-check.o
vhd-util-check.c
> cc1: warnings being treated as errors
> vhd-util-check.c: In function ‘vhd_util_check_vhd’:
> vhd-util-check.c:809: error: ‘footer.data_offset’ may be used uninitialized
> in this function
> vhd-util-check.c:809: error: ‘footer.type’ may be used uninitialized in
this
> function
I had a quick fix for this problem, with following patch. Perhaps that
is not the best way, but at least you can compile blktap2 with it.

For other compilation problems with blktap2, you can pick up the
patches I just post to the list.

Thanks,
J


diff -r 442fb5f1e0a2 tools/blktap2/vhd/lib/vhd-util-check.c
--- a/tools/blktap2/vhd/lib/vhd-util-check.c    Tue Jun 23 17:32:07 2009 +0100
+++ b/tools/blktap2/vhd/lib/vhd-util-check.c    Wed Jun 24 19:04:17 2009 +0900
@@ -808,6 +808,9 @@
     struct stat stats;
     vhd_footer_t footer;

+    footer.data_offset = 0;
+    footer.type = 0;
+
     fd = -1;
     memset(&vhd, 0, sizeof(vhd));

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel



      

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Thu, Jun 25, 2009 at 12:56 AM, Boris Derzhavets<bderzhavets@yahoo.com>
wrote:
> One more fix to build tools required :-
>
> ./tools/blktap2/drivers/lock.c
> line 253
>
>  -  if (!dptr & errno)    {
>  +  if ((!dptr) & errno) {
>
This is a wrong fix: it should be

+  if (!dptr && errno) {

This problem is already fixed in -stage.

Thanks,
J

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel