Re: [PATCH 1/4][Xen-devel] X86 microcode: cancel redundant input parameter of microcode functions

Keir Fraser
2009-01-22T11:14:18Z

On 22/01/2009 11:07, "Christoph Egger" <Christoph.Egger@amd.com>
wrote:

>> I think the input parameter ''cpu'' is better than
''uci'' since ''cpu'' is much
>> clear to developer with explicit meaning, so between the 2 redundant
>> parameters ''uci'' and ''cpu'', we
should remove ''uci'', just like what native
>> linux microcode functions do.
>
> What linux does, doesn''t matter here. Dom0 just has to make the
hypercall.
> This is nothing linux specific.

Like much of Xen''s low-level platform code, our microcode mechanism has
direct Linux heritage. Hence keeping as close as possible to those roots
makes upgrades from kernel.org upstream much easier. Hence there is good
reason for caring about closeness to Linux code compared with
solaris/bsd/...

 -- Keir