Xen devel - Nov 2008 - debuggers and hap_gva_to_gfn() in guest_walk.c

Debugger/s would like to keep it''s #ifdefs in xen minimal. Following
would help...

hap_gva_to_gfn():


+   if (v== current)
        mfn = mfn_x(gfn_to_mfn_current(gpfn, &p2mt));
+   else
+      mfn = mfn_x(gfn_to_mfn_foreign(v->domain, gpfn, &p2mt));


Thanks,
Mukesh


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

This looks like a bug in hap_gva_to_gfn(). It should probably be using
gfn_to_mfn() rather than gfn_to_mfn_current(). Tim, can you confirm?

 -- Keir

On 5/11/08 21:44, "Mukesh Rathor" <mukesh.rathor@oracle.com>
wrote:
> 
> Debugger/s would like to keep it''s #ifdefs in xen minimal.
Following would
> help...
> 
> hap_gva_to_gfn():
> 
> 
> +   if (v== current)
>         mfn = mfn_x(gfn_to_mfn_current(gpfn, &p2mt));
> +   else
> +      mfn = mfn_x(gfn_to_mfn_foreign(v->domain, gpfn, &p2mt));
> 
> 
> Thanks,
> Mukesh
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

At 21:56 +0000 on 05 Nov (1225922197), Keir Fraser
wrote:
> This looks like a bug in hap_gva_to_gfn(). It should probably be using
> gfn_to_mfn() rather than gfn_to_mfn_current(). Tim, can you confirm?
In the current codebase, it''s correct (all callers of
paging_gva_to_gfn()
call with v == current) but changing it to use gfn_to_mfn() seems
more correcter.

Tim.
> On 5/11/08 21:44, "Mukesh Rathor"
<mukesh.rathor@oracle.com> wrote:
> 
> > 
> > Debugger/s would like to keep it''s #ifdefs in xen minimal.
Following would
> > help...
> > 
> > hap_gva_to_gfn():
> > 
> > 
> > +   if (v== current)
> >         mfn = mfn_x(gfn_to_mfn_current(gpfn, &p2mt));
> > +   else
> > +      mfn = mfn_x(gfn_to_mfn_foreign(v->domain, gpfn, &p2mt));
> > 
> > 
> > Thanks,
> > Mukesh
> > 
> > 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xensource.com
> > http://lists.xensource.com/xen-devel
> 
> 
-- 
Tim Deegan <Tim.Deegan@citrix.com>
Principal Software Engineer, Citrix Systems (R&D) Ltd.
[Company #02300071, SL9 0DZ, UK.]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel