Re: [Xen-devel] [PATCH] fix asm syntax

John Levon
Tue, 17 Oct 2006 15:42:55 -0000

On Tue, Oct 17, 2006 at 04:33:32PM +0100, Jan Beulich wrote:

> >However, I don''t think there''s a disadvantage to the
more compatible
> >syntax, is there?
>
> While not producing bad side effects here (as Keir convinced me), it is
> generally wrong (i.e. it would work right only because of the more than
> odd constraint on the operand, which are needed to work around a
> quirk in the assembler that was fixed about ten months ago). However,
> the / prefix separation in general has been supported for far more than
> a year, so I wonder what specific problem you were seeing (and with
> how old an assembler)...

The standard GNU ld is currently still 2.15 on Solaris. If there''s
serious objections to not using the newer syntax, we can always keep it
as a local hack until we''ve updated. We''re releasing our
sources after
all.

regards,
john