Changeset 11598 broke the build with my gcc-4.1.2. You can''t forward-declare a static function within another function. Trivial patch attached to fix this. Signed-off-by: Charles Coffing <ccoffing@novell.com> gcc -O1 -fno-omit-frame-pointer -g -m32 -march=i686 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -nostdinc -fno-builtin -fno-common -fno-strict-aliasing -iwithprefix include -Werror -Wno-pointer-arith -pipe -I/usr/src/packages/BUILD/xen-unstable/xen/include -I/usr/src/packages/BUILD/xen-unstable/xen/include/asm-x86/mach-generic -I/usr/src/packages/BUILD/xen-unstable/xen/include/asm-x86/mach-default -msoft-float -g -D__XEN__ -DVERBOSE -DCRASH_DEBUG -c gdbstub.c -o gdbstub.o gdbstub.c: In function ‘gdbstub_attach’: gdbstub.c:363: error: invalid storage class for function ‘gdbstub_console_puts’ gdbstub.c:367: error: ‘gdbstub_console_puts’ undeclared (first use in this function) gdbstub.c:367: error: (Each undeclared identifier is reported only once gdbstub.c:367: error: for each function it appears in.) make[4]: *** [gdbstub.o] Error 1 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Mon, Sep 25, 2006 at 05:44:30PM -0400, Charles Coffing wrote:> Changeset 11598 broke the build with my gcc-4.1.2. You can''t > forward-declare a static function within another function. Trivial > patch attached to fix this.While you''re in there, it would be nice to do this right and move the declaration to a header file so that it doesn''t eventually (but certainly) get out of sync... Cheers, Muli _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel