Re: [Xen-devel] pointers in public headers

Keir Fraser
2006-08-25T14:14:25Z

On 25/8/06 2:15 pm, "Jan Beulich" <jbeulich@novell.com> wrote:

> While there are none there, even for those it would seem ill; but there
> pointers in
> - struct mmuext_op (xen.h)
> - struct vcpu_register_runstate_memory_area (vcpu.h)
> - struct xsd_errors (io/xs_wire.h)
> - struct ioreq (hvm/ioreq.h)

Io/xs_wire.h does not define a hypervisor interface so no need for guest
handles there. The rest are all x86-specific, and represent pointers that
don''t really cleanly fit into the guest handle model and its accessor
macros. Since on x86 the guest handle stuff is really only an enforcement
method for ensuring we use the correct accessors I just left the tricky few
as they were. Are you trying to macro/typedef the world for compat
compilation, and these are annoying for you? :-) If so we could hide them
behind a different macro -- we''d need to do that anyway to avoid
breaking
API compatibility.

 -- Keir