Xen devel - Aug 2006 - odd vcpu_info accesses in xen/arch/x86/time.c

Is there a particular reason why in several places in this file, with a vcpu
pointer
at hand, the vcpu_info is accessed through

	v->domain->shared_info->vcpu_info[v->vcpu_id]

rather than

	v->vcpu_info

Thanks, Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 29/8/06 3:56 pm, "Jan Beulich" <jbeulich@novell.com> wrote:
> Is there a particular reason why in several places in this file, with a
vcpu
> pointer
> at hand, the vcpu_info is accessed through
> 
> v->domain->shared_info->vcpu_info[v->vcpu_id]
> 
> rather than
> 
> v->vcpu_info
No. They should be fixed.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

>>> Keir Fraser <Keir.Fraser@cl.cam.ac.uk> 30.08.06 18:27
>>>
>On 29/8/06 3:56 pm, "Jan Beulich" <jbeulich@novell.com>
wrote:
>
>> Is there a particular reason why in several places in this file, with a
vcpu
>> pointer
>> at hand, the vcpu_info is accessed through
>> 
>> v->domain->shared_info->vcpu_info[v->vcpu_id]
>> 
>> rather than
>> 
>> v->vcpu_info
>
>No. They should be fixed.
Signed-off-by: Jan Beulich <jbeulich@novell.com>

Index: 2006-08-28/xen/arch/x86/time.c
==================================================================---
2006-08-28.orig/xen/arch/x86/time.c	2006-08-31 09:52:31.000000000 +0200
+++ 2006-08-28/xen/arch/x86/time.c	2006-08-31 09:55:54.000000000 +0200
@@ -676,7 +676,7 @@ static inline void __update_vcpu_system_
     struct vcpu_time_info *u;
 
     t = &this_cpu(cpu_time);
-    u = &v->domain->shared_info->vcpu_info[v->vcpu_id].time;
+    u = &v->vcpu_info->time;
 
     version_update_begin(&u->version);
 
@@ -690,7 +690,7 @@ static inline void __update_vcpu_system_
 
 void update_vcpu_system_time(struct vcpu *v)
 {
-    if (
v->domain->shared_info->vcpu_info[v->vcpu_id].time.tsc_timestamp !=
+    if ( v->vcpu_info->time.tsc_timestamp !         
this_cpu(cpu_time).local_tsc_stamp )
         __update_vcpu_system_time(v);
 }


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel