Jun, following sysret_signal there is a ''cli'' left, but the hypervisor doesn''t even emulate this anymore as equivalent of clearing evtchn_upcall_mask - I''m fairly certain XEN_BLOCK_EVENTS() is meant here, otherwise a comment should explain why this needs to keep the native instruction. Thanks for your opinion, Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 8/8/06 8:34 am, "Jan Beulich" <jbeulich@novell.com> wrote:> following sysret_signal there is a ''cli'' left, but the hypervisor doesn''t even > emulate this anymore as equivalent of > clearing evtchn_upcall_mask - I''m fairly certain XEN_BLOCK_EVENTS() is meant > here, otherwise a comment should explain > why this needs to keep the native instruction.Any stupidities you see in x86/64 entry-xen.S almost certainly really are bugs. Please send a patch! -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jan Beulich
2006-Aug-14 12:56 UTC
[PATCH] Re: [Xen-devel] omission in x86-64''s entry-xen.S ?
>> following sysret_signal there is a ''cli'' left, but the hypervisordoesn''t even>> emulate this anymore as equivalent of >> clearing evtchn_upcall_mask - I''m fairly certain XEN_BLOCK_EVENTS()is meant>> here, otherwise a comment should explain >> why this needs to keep the native instruction. > >Any stupidities you see in x86/64 entry-xen.S almost certainly reallyare>bugs. Please send a patch!Here we (finally) go: This fixes - one instance of using XEN_BLOCK_EVENTS where XEN_UNBLOCK_EVENTS was meant - four instances of left-over cli-s that should have been replaced with XEN_BLOCK_EVENTS - one instance of slightly wrong placement (without resulting in ill behavior, but needlessly making the diff to native more complex) Signed-off-by: Jan Beulich <jbeulich@novell.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel