RE: [Xen-devel] [PATCH] "lock cmpxch8b" and split locks

Puthiyaparambil, Aravindh
Thu, 06 Oct 2005 04:53:27 -0000

Keir,

Sorry about breaking x86_32.

The fixed up patch takes care of the misalignment.

Thanks,
Aravindh
PS: Please ignore my message below.

> -----Original Message-----
> From: xen-devel-bounces@lists.xensource.com [mailto:xen-devel-
> bounces@lists.xensource.com] On Behalf Of Puthiyaparambil, Aravindh
> Sent: Wednesday, October 05, 2005 6:51 PM
> To: Keir Fraser
> Cc: Koren, Bradley J; xen-devel@lists.xensource.com; Vessey, Bruce A;
> Subrahmanian, Raj
> Subject: RE: [Xen-devel] [PATCH] "lock cmpxch8b" and split locks
>
> I just realized that moving ''tlbflush_timestamp'' to the
end of the
> structure will make us trip up on cmpxchg(&page->u.inuse.type_info,
x,
> nx) in put_page_type().
>
> I think we have to come up with an alternative solution.
>
> Aravindh
>
> > -----Original Message-----
> > From: Keir Fraser [mailto:Keir.Fraser@cl.cam.ac.uk]
> > Sent: Wednesday, October 05, 2005 6:40 PM
> > To: Puthiyaparambil, Aravindh
> > Cc: Vessey, Bruce A; xen-devel@lists.xensource.com; Koren, Bradley
J;
> > Subrahmanian, Raj
> > Subject: Re: [Xen-devel] [PATCH] "lock cmpxch8b" and split
locks
> >
> >
> > On 5 Oct 2005, at 23:16, Puthiyaparambil, Aravindh wrote:
> >
> > > Which looks something like my attachment? :-)
> > >
> > > Signed off by: Aravindh Puthiyaparambil
> > > <aravindh.puthiyaparambil@unisys.com>
> >
> > Turns out it breaks x86/64. I checked in a fixed up version.
> >
> >   -- Keir
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel