remove possible memory leaks. Signed-off-by: Jerone Young <jyoung5@us.ibm.com> --- tools/libxc/xc_linux_save.c.old 2005-08-11 13:14:35.000000000 -0500 +++ tools/libxc/xc_linux_save.c 2005-08-11 13:25:08.000000000 -0500 @@ -1053,7 +1053,18 @@ int xc_linux_save(int xc_handle, int io_ if (pfn_type != NULL) free(pfn_type); + + if (pfn_batch != NULL) + free(pfn_batch); + if (to_send != NULL) + free(to_send); + + if (to_fix != NULL) + free(to_fix); + + if (to_skip != NULL) + free(to_skip); DPRINTF("Save exit rc=%d\n",rc); return !!rc; } -- Jerone Young IBM Linux Technology Center jyoung5@us.ibm.com 512-838-1157 (T/L: 678-1157) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Thu, Aug 11, 2005 at 04:15:13PM -0500, Jerone Young wrote:> if (pfn_type != NULL) > free(pfn_type); > + > + if (pfn_batch != NULL) > + free(pfn_batch); > > + if (to_send != NULL) > + free(to_send); > + > + if (to_fix != NULL) > + free(to_fix); > + > + if (to_skip != NULL) > + free(to_skip);free checks for null pointer themself. Bastian -- Extreme feminine beauty is always disturbing. -- Spock, "The Cloud Minders", stardate 5818.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Fri, Aug 12, 2005 at 12:17:59PM +0200, Bastian Blank wrote:> > + if (to_skip != NULL) > > + free(to_skip); > > free checks for null pointer themself.Indeed. I got a cleanup of thoses use, that i''m going to push later. -- Vincent Hanquez _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel