Fix 64 bit build.
Signed-off-by: Nitin Kamble <nitin.a.kamble@intel.com>
Signed-off-by: Arun Sharma <arun.sharma@intel.com>
--- a/tools/firmware/vmxassist/head.S Fri Jun 10 17:48:42 2005
+++ b/tools/firmware/vmxassist/head.S Fri Jun 10 15:08:15 2005
@@ -135,7 +135,7 @@
.align 4
.globl halt
halt:
- pushl $halt_msg
+ push $halt_msg
call printf
#ifdef TEST
movw $0x8A00, %dx
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
On 10 Jun 2005, at 23:09, Arun Sharma wrote:> Fix 64 bit build. > > Signed-off-by: Nitin Kamble <nitin.a.kamble@intel.com> > Signed-off-by: Arun Sharma <arun.sharma@intel.com>Surely the correct fix is to put a .code32 at the top of the file? The vmxassist stuff should run in 32-bit protected mode: long mode doesn''t necessarily support VM86 mode (not on amd chips I believe). I think the checked-in fix is benign but not the right run-time fix. :-) -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel