On 10 Jun 2005, at 09:32, aq wrote:> This patch moves declaration of xs_handle from xs.c to xs.h. Besides, > it installs xs.h and xs_lib.h to /usr/include, and gets top Makefile > uninstalled them when cleaning up.The handle is deliberately opaque. We''ll take the Makefile patches though. Thanks, Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
This patch moves declaration of xs_handle from xs.c to xs.h. Besides, it installs xs.h and xs_lib.h to /usr/include, and gets top Makefile uninstalled them when cleaning up. Signed-off-by: Nguyen Anh Quynh <aquynh@gmail.com> # diffstat xenstore2.patch Makefile | 1 + tools/xenstore/Makefile | 2 ++ tools/xenstore/xs.c | 5 ----- tools/xenstore/xs.h | 5 ++++- 4 files changed, 7 insertions(+), 6 deletions(-) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Fri, 2005-06-10 at 03:32 -0500, aq wrote:> This patch moves declaration of xs_handle from xs.c to xs.h.No; why do this? It''s opaque for a reason. Originally it was just an int, but Keir insisted it be an opaque structure. Exposing it binds us to the current structure again.> Besides, > it installs xs.h and xs_lib.h to /usr/include, and gets top Makefile > uninstalled them when cleaning up.xs_lib.h should not be installed in /usr/include! Rusty. -- A bad analogy is like a leaky screwdriver -- Richard Braakman _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 6/12/05, Rusty Russell <rusty@rustcorp.com.au> wrote:> On Fri, 2005-06-10 at 03:32 -0500, aq wrote: > > This patch moves declaration of xs_handle from xs.c to xs.h. > > No; why do this? It''s opaque for a reason. Originally it was just an > int, but Keir insisted it be an opaque structure. Exposing it binds us > to the current structure again. > > > Besides, > > it installs xs.h and xs_lib.h to /usr/include, and gets top Makefile > > uninstalled them when cleaning up. > > xs_lib.h should not be installed in /usr/include!i see that, but where should we put this header? regards, aq _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Mon, 2005-06-13 at 00:14 +0900, aq wrote:> On 6/12/05, Rusty Russell <rusty@rustcorp.com.au> wrote: > > On Fri, 2005-06-10 at 03:32 -0500, aq wrote: > > > This patch moves declaration of xs_handle from xs.c to xs.h. > > > > No; why do this? It''s opaque for a reason. Originally it was just an > > int, but Keir insisted it be an opaque structure. Exposing it binds us > > to the current structure again. > > > > > Besides, > > > it installs xs.h and xs_lib.h to /usr/include, and gets top Makefile > > > uninstalled them when cleaning up. > > > > xs_lib.h should not be installed in /usr/include! > > i see that, but where should we put this header?Once the daemon and library are built, it''s not necessary for anything. Rusty. -- A bad analogy is like a leaky screwdriver -- Richard Braakman _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 6/14/05, Rusty Russell <rusty@rustcorp.com.au> wrote:> On Mon, 2005-06-13 at 00:14 +0900, aq wrote: > > On 6/12/05, Rusty Russell <rusty@rustcorp.com.au> wrote: > > > On Fri, 2005-06-10 at 03:32 -0500, aq wrote: > > > > This patch moves declaration of xs_handle from xs.c to xs.h. > > > > > > No; why do this? It''s opaque for a reason. Originally it was just an > > > int, but Keir insisted it be an opaque structure. Exposing it binds us > > > to the current structure again. > > > > > > > Besides, > > > > it installs xs.h and xs_lib.h to /usr/include, and gets top Makefile > > > > uninstalled them when cleaning up. > > > > > > xs_lib.h should not be installed in /usr/include! > > > > i see that, but where should we put this header? > > Once the daemon and library are built, it''s not necessary for anything. >i installed xs_lib.h because xs.h includes it. now we need to remove this and include xs_lib.h in other files as needed. later i will send in another patch to fix this, and revert the problem raised in last patch. regards, aq _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Tue, 2005-06-14 at 13:46 +0900, aq wrote:> On 6/14/05, Rusty Russell <rusty@rustcorp.com.au> wrote: > > On Mon, 2005-06-13 at 00:14 +0900, aq wrote: > > > On 6/12/05, Rusty Russell <rusty@rustcorp.com.au> wrote: > > > > On Fri, 2005-06-10 at 03:32 -0500, aq wrote: > > > > > This patch moves declaration of xs_handle from xs.c to xs.h. > > > > > > > > No; why do this? It''s opaque for a reason. Originally it was just an > > > > int, but Keir insisted it be an opaque structure. Exposing it binds us > > > > to the current structure again. > > > > > > > > > Besides, > > > > > it installs xs.h and xs_lib.h to /usr/include, and gets top Makefile > > > > > uninstalled them when cleaning up. > > > > > > > > xs_lib.h should not be installed in /usr/include! > > > > > > i see that, but where should we put this header? > > > > Once the daemon and library are built, it''s not necessary for anything. > > > > i installed xs_lib.h because xs.h includes it. now we need to remove > this and include xs_lib.h in other files as needed.True. More logical to move the xs_permissions struct to xs.h, I think. Rusty. -- A bad analogy is like a leaky screwdriver -- Richard Braakman _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel