This patch (attached because thunderbird messes with whitespace) moves some constants from xen/drivers/char/serial.c to xen/include/xen/serial.h. On PPC I want to do this: static int ns16550_putc(struct uart *uart, unsigned char c) { if (inb(uart->io_base + LSR) & LSR_THRE) { outb(c, uart->io_base + THR); return 1; } return 0; } int arch_serial_putc(struct uart *uart, unsigned char c) { if (on_simulator()) return sim_putc(c); return ns16550_putc(uart, c); } ... and that means arch code needs to be able to see struct uart, LSR, etc. I also notice that ia64 already made a private copy of these defines. I have verified that this patch builds on x86 and ia64. -- Hollis Blanchard IBM Linux Technology Center _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel