[PATCH 01/23] block: factor out a bvec_set_page helper

David Howells
2023-01-30T10:33:36Z

Christoph Hellwig <hch at lst.de> wrote:

> +static inline void bvec_set_page(struct bio_vec *bv, struct page *page,
> +		unsigned int len, unsigned int offset)

Could you swap len and offset around?  It reads better offset first.  You move
offset into the page and then do something with len bytes.

David