[PATCH 14/29] fsdax: simplify the pgoff calculation

Christoph Hellwig
Wed, 24 Nov 2021 06:39:34 -0000

On Tue, Nov 23, 2021 at 02:36:42PM -0800, Darrick J. Wong
wrote:
> > -	phys_addr_t phys_off = (start_sect + sector) * 512;
> > -
> > -	if (pgoff)
> > -		*pgoff = PHYS_PFN(phys_off);
> > -	if (phys_off % PAGE_SIZE || size % PAGE_SIZE)
>
> AFAICT, we're relying on fs_dax_get_by_bdev to have validated this
> previously, which is why the error return stuff goes away?

Exactly.