[PATCH] vdpa/mlx5: fix param validation in mlx5_vdpa_get_config()

Jason Wang
Wed, 10 Feb 2021 04:17:19 -0000

On 2021/2/9 ??5:00, Stefano Garzarella wrote:
> On Tue, Feb 09, 2021 at 07:43:02AM +0200, Eli Cohen wrote:
>> On Mon, Feb 08, 2021 at 05:17:41PM +0100, Stefano Garzarella wrote:
>>> It's legal to have 'offset + len' equal to
>>> sizeof(struct virtio_net_config), since 'ndev->config'
is a
>>> 'struct virtio_net_config', so we can safely copy its
content under
>>> this condition.
>>>
>>> Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported
mlx5
>>> devices")
>>> Cc: stable at vger.kernel.org
>>> Signed-off-by: Stefano Garzarella <sgarzare at redhat.com>
>>
>> Acked-by: Eli Cohen <elic at nvidia.com>
>>
>> BTW, same error in vdpa_sim you may want to fix.
>>
>
> Commit 65b709586e22 ("vdpa_sim: add get_config callback in
> vdpasim_dev_attr") unintentionally solved it.
>
> Since it's a simulator, maybe we can avoid solving it in the stable
> branches. Or does it matter?


I think not, since the module depends on RUNTIME_TESTING_MENU.

Thanks




>
> Thanks,
> Stefano