[PATCH] headers: untangle kmemleak.h from mm.h

Randy Dunlap
Wed, 14 Feb 2018 00:48:44 -0000

On 02/11/2018 11:27 PM, Ingo Molnar wrote:
>
> * Randy Dunlap <rdunlap at infradead.org> wrote:
>
>> From: Randy Dunlap <rdunlap at infradead.org>
>>
>> Currently <linux/slab.h> #includes <linux/kmemleak.h> for
no obvious
>> reason. It looks like it's only a convenience, so remove kmemleak.h
>> from slab.h and add <linux/kmemleak.h> to any users of kmemleak_*
>> that don't already #include it.
>> Also remove <linux/kmemleak.h> from source files that do not use
it.
>>
>> This is tested on i386 allmodconfig and x86_64 allmodconfig. It
>> would be good to run it through the 0day bot for other $ARCHes.
>> I have neither the horsepower nor the storage space for the other
>> $ARCHes.
>>
>> [slab.h is the second most used header file after module.h; kernel.h
>> is right there with slab.h. There could be some minor error in the
>> counting due to some #includes having comments after them and I
>> didn't combine all of those.]
>>
>> This is Lingchi patch #1 (death by a thousand cuts, applied to kernel
>> header files).
>>
>> Signed-off-by: Randy Dunlap <rdunlap at infradead.org>
>
> Nice find:
>
> Reviewed-by: Ingo Molnar <mingo at kernel.org>
>
> I agree that it needs to go through 0-day to find any hidden dependencies
we might
> have grown due to this.

Andrew,

This patch has mostly survived both 0day and ozlabs multi-arch testing with
2 build errors being reported by both of them.  I have posted patches for
those separately. (and are attached here)

other-patch-1:
lkml.kernel.org/r/5664ced1-a0cd-7e4e-71b6-9c3a97d68927 at infradead.org
"lib/test_firmware: add header file to prevent build errors"

other-patch-2:
lkml.kernel.org/r/b3b7eebb-0e9f-f175-94a8-379c5ddcaa86 at infradead.org
"integrity/security: fix digsig.c build error"

Will you see that these are merged or do you want me to repost them?

thanks,
--
~Randy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: integrity_security_digsig_add_header.patch
Type: text/x-patch
Size: 872 bytes
Desc: not available
URL:
<http://lists.linuxfoundation.org/pipermail/virtualization/attachments/20180213/113a3372/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lib_test_firmware_add_header_file.patch
Type: text/x-patch
Size: 1024 bytes
Desc: not available
URL:
<http://lists.linuxfoundation.org/pipermail/virtualization/attachments/20180213/113a3372/attachment-0001.bin>