[RFC PATCH 03/11] PCI/MSI: Refactor pci_dev_msi_enabled()

Stuart Yoder
2014-08-05T22:35:04Z

On Fri, Jul 25, 2014 at 10:08 PM, Yijing Wang <wangyijing at huawei.com>
wrote:
> Pci_dev_msi_enabled() is used to check whether device
> MSI/MSIX enabled. Refactor this function  to suuport
> checking only device MSI or MSIX enabled.
>
> Signed-off-by: Yijing Wang <wangyijing at huawei.com>

So this patch refactors things so that checks like this:
   > -       if (!dev->msi_enabled)

are moved into a function:
   > +       if (!pci_dev_msi_enabled(dev, MSI_TYPE))

Can you explain a bit more why this  needed.   Is it just cleanup?

Thanks,
Stuart