[PATCH] virtio-spec: add field for scsi command size

Paolo Bonzini
Thu, 04 Jul 2013 09:05:13 -0000

Il 04/07/2013 09:39, Michael S. Tsirkin ha scritto:
>>>>> > > > > Mainly because I'm not sure that
*all* devices are now safe.  Are they?
>>>> > > >
>>>> > > > virtio-scsi's implementation in QEMU is not
safe (been delaying that for
>>>> > > > too long, sorry), but the spec is safe.
>>> > >
>>> > > Then if we added a transport feature, we couldn't use
it :(
>> >
>> > Transport feature bits are still negotiated per device though.
>> > virtio-scsi devices in QEMU would not negotiate that feature.
>> >
>> > Paolo
>> >
>>> > > So I think it needs to be a per-device feature bit.
> We don't know that it's helpful for any devices besides -net
> so I'd say keep it simple.

Then we should stop calling it a "device model bug".

If we call it a bug, we must strive for support in all devices.  If we
don't care, we should stop calling it a bug.

Paolo