[PATCH] virtio-spec: add field for scsi command size

Michael S. Tsirkin
Thu, 04 Jul 2013 07:39:12 -0000

On Mon, Jul 01, 2013 at 01:57:44PM +0200, Paolo Bonzini
wrote:
> Il 01/07/2013 01:47, Rusty Russell ha scritto:
> > > >
> > > > Mainly because I'm not sure that *all* devices are now
safe.  Are they?
> > >
> > > virtio-scsi's implementation in QEMU is not safe (been
delaying that for
> > > too long, sorry), but the spec is safe.
> >
> > Then if we added a transport feature, we couldn't use it :(
>
> Transport feature bits are still negotiated per device though.
> virtio-scsi devices in QEMU would not negotiate that feature.
>
> Paolo
>
> > So I think it needs to be a per-device feature bit.

We don't know that it's helpful for any devices besides -net
so I'd say keep it simple.

--
MST