Automatic code formatting

Guus Sliepen
Wed, 25 Oct 2017 17:19:47 -0000

On Wed, Oct 25, 2017 at 10:10:06AM -0600, Todd C. Miller wrote:

> > I'll also run sed on the codebase to add parentheses around the
argument
> > of sizeof operators, since code formatters otherwise turn "sizeof
*foo"
> > into "sizeof * foo".
>
> Not all "sizeof foo" were converted to "sizeof(foo)".
I've opened
> a pull request with a patch: https://github.com/gsliepen/tinc/pull/158

Oh how silly, it looks like I ran sed without the /g flag, and it only
converted the first sizeof of every line. Thanks for the patch!

> If you'd rather I send a patch directly I'm happy to do that
instead.

I accept patches in all forms :)

--
Met vriendelijke groet / with kind regards,
     Guus Sliepen <guus at tinc-vpn.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL:
<http://www.tinc-vpn.org/pipermail/tinc-devel/attachments/20171025/426528bb/attachment.sig>