[syslinux] [PATCH 5/5] installers: fix a MinGW redefinition warning

Pete Batard
Wed, 24 Feb 2016 13:02:46 -0000

I get a redefinition warning on _GNU_SOURCE when compiling with MinGW,
and while I could see that this #define was introduced in e4fc44 [1],
but the reason to introduce it is not mentioned, and I can't really see
a good reason to have it, especially as MSVC will happily compile that
source. So far I have found no evidence that _GNU_SOURCE applies to
memset/memmove/memcpy, which are the only calls I see in there that I
could see impacted. Besides, for obvious compatibility reasons, I would
advocate using -D_GNU_SOURCE as a compiler option if one really needs
it, rather than have it in a source (which is what Syslinux already
seems to do elsewhere).

[1]
https://github.com/geneC/syslinux/commit/e4fc443f9b70f188963ff33e0a16ccb72a553540
-------------- next part --------------