[syslinux] [PATCH 2/2] core/graphics: fix lss16 parsing

Patrick Masotta
Sun, 23 Aug 2015 07:33:37 -0000

>>>
> Please take a moment and see what the quoted code does; it'll save you
lot of time.

 I wrote my versions before I knew about the other code.?
<<<

Yes, but you published your patches after you knew about it.


>>>
 Unfortunately,
 that other code is a massive single patch and would be hard to review
 since it would be difficult to bisect should a bug be introduced.? I
 will try to split the other patch into logical parts and submit as time
 permits.
 <<<

Yes I know; unfortunately solving the lss16 issue cannot be done with a couple
of 4 line patches.
The code to fix was originally ported to C from the assembler of a previous SL
version, and it
never really worked before; it was needed re-writing certain parts.
Now the new code ( http://www.syslinux.org/archives/2015-July/023835.html ) has
been
tested and it does work (you can see an lss16 image in your terminal). I always
prefer start
fixing things from a working code base than start patching one that never did.

if you want to continue with the task probably it's more valuable if you try
to tackle
the associated issues related to terminal/cli handling rather that splitting the
big patch.
just my 2 cents.

Best,
Patrick