similar to: [PATCH] x86 emulation: suppress rep prefix handling on non-repeatable instructions

Utilize some of the additions in the prior patches to clean up other code: - keep track of REP prefixes in only one variable - use REX_W in a few more places (instead of a literal number) Signed-off-by: Jan Beulich <jbeulich@suse.com> --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -304,6 +304,10 @@ union vex { ptr[1] = rex |

These instructions are prefix selected flavors of bsf and bsr respectively, and hence the presences of the F3 prefix must be handled in the emulation code in order to avoid running into problems on newer CPUs. Signed-off-by: Jan Beulich <jbeulich@suse.com> --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -1058,6 +1058,9 @@ static bool_t vcpu_has(

Commit 86781624 ("x86_emulate: PUSH <mem> must read source operand just once") corrected the operands of those of the operations of opcode extension group 5 that only read memory from SrcMem to DstMem, but failed to also switch the use of "dst" here to "src". Reported-by: Anthony Perard <anthony.perard@citrix.com> Signed-off-by: Jan Beulich

With the x86 instruction emulator no pretty complete, I''d like to re-submit this patch to support cmpxchg16b on x86-64 and at once rename the underlying emulator callback function pointer (making clear that if implemented, it is to operate on two longs rather than two 32-bit values). At the same time it fixes an apparently wrong emulator context initialization in the shadow code.

Hi all, In arch/x86/x86_emulate.c: x86_emulate(): 1716 case 0xfe: /* Grp4 */ 1717 generate_exception_if((m odrm_reg & 7) >= 2, EXC_UD); 1718 case 0xff: /* Grp5 */ 1719 switch ( modrm_reg & 7 ) 1720 { 1721 case 0: /* inc */ 1722 emulate_1op("inc", dst, _regs.eflags); 1723 break; 1724

Clone the existing movq emulation to also support the most fundamental SIMD FP moves. Extend the testing code to also exercise these instructions. Signed-off-by: Jan Beulich <jbeulich@suse.com> --- a/tools/tests/x86_emulator/test_x86_emulator.c +++ b/tools/tests/x86_emulator/test_x86_emulator.c @@ -629,6 +629,60 @@ int main(int argc, char **argv) else

We''ve got reports of that change causing HVM data corruption issues. While I can''t see what''s wrong with the patch, I''d suggest at least reverting it from the 3.3 tree (which is what our code is based upon) for the time being. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com

- we used the C4/C5 (first prefix) byte instead of the apparent ModR/M one as the second prefix byte - early decoding normalized vex.reg, thus corrupting it for the main consumer (copy_REX_VEX()), resulting in #UD on the two-operand instructions we emulate Also add respective test cases to the testing utility plus - fix get_fpu() (the fall-through order was inverted) - add cpu_has_avx2,

Hi Keir: I am sorry trouble you again. I want to emulate instruction "push %ebp" in Xen. I found the function emulate_privilege_op does not satisfy this requirement. Then I resort to x86_emulate. I construct the x86_emulate_ctxt and reuse the "ptwr_emulate_ops". code like this: extern const struct x86_emulate_ops ptwr_emulate_ops; in do_general_protection { .... struct

I do recieve this error when building xen-unstable tree. gcc -O2 -fomit-frame-pointer -m32 -march=i686 -DNDEBUG -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement -DVMXASSIST -nostdinc -fno-builtin -fno-common -iwithprefix include -Werror -Wno-pointer-arith -pipe -I/home/xen-unstable.hg/xen/include

Hi, I was trying to write printk statements in x86_emulate.c and I am getting following error. cc1: warnings being treated as errors x86_emulate.c: In function ''x86_emulate'': x86_emulate.c:2913: warning: ISO C90 forbids mixed declarations and code x86_emulate.c:2939: warning: ISO C90 forbids mixed declarations and code Yes, I know probably I can make changes in Makefile to

Hi, I was trying to write printk statements in x86_emulate.c and I am getting following error. cc1: warnings being treated as errors x86_emulate.c: In function ''x86_emulate'': x86_emulate.c:2913: warning: ISO C90 forbids mixed declarations and code x86_emulate.c:2939: warning: ISO C90 forbids mixed declarations and code Yes, I know probably I can make changes in Makefile to

Hi, Keir, This patch is to fix the problem of Linux guest installation failure and Windows 2000 boot failure.       In the early code, we use vmx_vmexit_handler() -> vmx_io_instruction() function to emulate I/O instructions. But now, we use vmx_vmexit_handler() -> handle_mmio -> hvm_emulate_one() -> x86_emulate() to emulate I/O instructions. Also nowadays, the realmode

This patch adds a number of fp instructions needed for OS/2 to boot as a HVM guest on Intel/VT hardware. It appears to work fine, and OS/2 is now finally working on Intel/VT as well as AMD/SVM. I''m a little concerned about the "correctness" of the FSTSW emulation and the use of inline assembly directly using the corresponding ops for emulation. Wrt FSTSW, it is really two ops

All, in the light of erratum #573 I''m wondering if we need to tweak or conditionally suppress fsincos emulation. The question is whether there is any possibility for getting the emulator to hit this instruction on AMD (as no real mode emulation ought to be taking place there), i.e. whether there are places where emulation gets continued eagerly in anticipation of the need for emulation

Contrary to the pxelinux.doc documentation, the common filename prefix is only suppressed if an explicit hostname or IP address precedes the double colon, e.g. 192.168.1.1::/foobar. A tcpdump of TFTP requests reveals that the double colon does nothing in implicit case (::/foobar is the same as /foobar, i.e. gets mapped to /pxelinux//foobar or whatever). 0.0.0.0::/foobar also does this. I

Just a reminder that this remains an issue up to and including the latest syslinux 3.53-pre (0x473cfc9c). Additional testing suggests that implicit hostname/IP has never worked, ever since the common prefix suppression feature was added in version 3.00. -------- Original Message -------- Subject: pxelinux doesn't suppress common prefix if nothing precedes double colon Date: Sat, 25 Aug

The lmsw instruction can be used to set CR0_PE, but can never clear it, once set. Currently, as far as I can see, there is no provision to keep lmsw from clearing CR0_PE, either in the vmx code or in x86_emulate code (which is used by SVM to emulate lmsw). This patch fixes this issue. Signed-off-by: Trolle Selander <trolle.selander@eu.citrix.com>

> Hmmm... wouldn''t it be nice if we didn''t have a bespoke, > buggy & incomplete emulator for hvm mmio. ;-) In the process of solving this one, I''ve got to (another) of the blocking points... At the moment, we translate the virtual address from the guest in the page-fault-handler to guest physical address via the gva_to_gpa() function in svm.c/vmx.c:

Hi there, I have a question regarding the functionality of x86_emulate_memop (Xen 3.1) or x86_emulate (Xen 3.2) function. This function gets called from sh_page_fault() function which is invoked when Xen receives a page fault. Since I am not clear completely about the emulation operation performed by Xen, I have following questions with a below mentioned scenario? 1) Suppose I have a memory