similar to: BUG? a racy code at o2hb_heartbeat_group_drop_item()

upstream commit 2ad49887150894b9ed6a87a76b409adceee6b074 Motivated from the commit, I found that cleaner_kthread() and transaction_kthread() can result similar error since these two function can exit even though kthread_should_stop() is not true. In order to resolve the bug, break statements are changed into continue statements in order to wait until kthread_should_stop() becomes true. ---

Signed-off-by: Karol Herbst <nouveau at karolherbst.de> --- drm/nouveau/nvkm/subdev/clk/base.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drm/nouveau/nvkm/subdev/clk/base.c b/drm/nouveau/nvkm/subdev/clk/base.c index 7f86e41..d6f239f 100644 --- a/drm/nouveau/nvkm/subdev/clk/base.c +++ b/drm/nouveau/nvkm/subdev/clk/base.c @@ -319,14 +319,11 @@

[ This is ancient code. - dan ] fs/fs_context.c 168 { 169 int ret; 170 171 struct fs_parameter param = { 172 .key = key, 173 .type = fs_value_is_flag, 174 .size = v_size, 175 }; 176 177 if (value) { --> 178 param.string =

Commit 5ac00add added a testnset mutex and code that disallows running administrative tasks in parallel. It is prevented that the device add/delete/balance/replace/resize operations are started in parallel. By mistake, the defragmentation operation was included in the check for mutually exclusiveness as well. This is fixed with this commit. Signed-off-by: Stefan Behrens

this function just forces a reclock. This makes sense if some cstates get (un)available and we have to adjust to that. This can happen for various reasons: * temperature changes * user changes boost mode Signed-off-by: Karol Herbst <nouveau at karolherbst.de> --- drm/nouveau/include/nvkm/subdev/clk.h | 1 + drm/nouveau/nvkm/subdev/clk/base.c | 23 ++++++++++++++++------- 2 files

We don't want to change anything on the GPU if it's suspended. Also we need to increase the refcount on the pm_runtime counter so that the GPU won't be suspended while reclocking. Signed-off-by: Karol Herbst <karolherbst at gmail.com> --- drm/nouveau/nvkm/subdev/clk/base.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

On 02/26, Waiman Long wrote: > > +void queue_spin_lock_slowpath(struct qspinlock *lock, int qsval) > +{ > + unsigned int cpu_nr, qn_idx; > + struct qnode *node, *next; > + u32 prev_qcode, my_qcode; > + > + /* > + * Get the queue node > + */ > + cpu_nr = smp_processor_id(); > + node = get_qnode(&qn_idx); > + > + /* > + * It should never happen

On 02/26, Waiman Long wrote: > > +void queue_spin_lock_slowpath(struct qspinlock *lock, int qsval) > +{ > + unsigned int cpu_nr, qn_idx; > + struct qnode *node, *next; > + u32 prev_qcode, my_qcode; > + > + /* > + * Get the queue node > + */ > + cpu_nr = smp_processor_id(); > + node = get_qnode(&qn_idx); > + > + /* > + * It should never happen

Signed-off-by: Karol Herbst <nouveau at karolherbst.de> --- drm/nouveau/nvkm/subdev/clk/base.c | 19 +++++++++++-------- drm/nouveau/nvkm/subdev/clk/gf100.c | 4 ++-- drm/nouveau/nvkm/subdev/clk/nv40.c | 2 +- drm/nouveau/nvkm/subdev/clk/priv.h | 6 +++--- 4 files changed, 17 insertions(+), 14 deletions(-) diff --git a/drm/nouveau/nvkm/subdev/clk/base.c

On Tue, 8 Oct 2024 at 00:25, Laurent Pinchart <laurent.pinchart at ideasonboard.com> wrote: > > Hi Ulf, > > On Tue, Oct 08, 2024 at 12:08:24AM +0200, Ulf Hansson wrote: > > On Mon, 7 Oct 2024 at 20:49, Laurent Pinchart wrote: > > > On Fri, Oct 04, 2024 at 04:38:36PM +0200, Ulf Hansson wrote: > > > > On Fri, 4 Oct 2024 at 11:41, Sakari Ailus wrote: >

On Tue, Oct 8, 2024 at 12:35?AM Ulf Hansson <ulf.hansson at linaro.org> wrote: > > On Tue, 8 Oct 2024 at 00:25, Laurent Pinchart > <laurent.pinchart at ideasonboard.com> wrote: > > > > Hi Ulf, > > > > On Tue, Oct 08, 2024 at 12:08:24AM +0200, Ulf Hansson wrote: > > > On Mon, 7 Oct 2024 at 20:49, Laurent Pinchart wrote: > > > > On

this function will be used to update the current clock state. This will happen for various reasons: * temperature changes (may change cstate and/or voltage) * user changes boost mode * load changes v2: add wait parameter Signed-off-by: Karol Herbst <nouveau at karolherbst.de> --- drm/nouveau/include/nvkm/subdev/clk.h | 1 + drm/nouveau/nvkm/subdev/clk/base.c | 46

Hi, I am looking for thoughts on the following LLVM transformation. Consider the following transformation which replaces conditional load(a) with load(a);select instructions. Source -------- int a; bool flag; int readA() { int r=0; if(flag) { r = a; } return r; } Command -------- clang++ -std=c++11 -pthread -emit-llvm <filename>.cpp -S;opt -O3 <filename>.ll -o

Hi, I agree that the earlier example was already racy due to shared flag variable. Sorry for the wrong example. Please ignore it. I have modified the program as follows. The only shared variable is 'a' and the following is a non-racy program. int a; int readA(bool flag) { int r=0; if(flag) { r = a; } return r; } void writeA(){ a = 42; } int main() { bool flag = false;

Hi all, Writing up some Fedora documentation, and looking to figure out the best way of mapping multipath network(!) LUNs to pools in libvirt. ie Infiniband SRP LUNs, but would probably apply to Fibre Channel equally as well. There are two approaches I can think of easily: a) Large LUNs (ie TB+) that are mapped to a host server as disk, with each LUN being configured as an LVM

This is interesting! So are you saying that loop.parallel_accesses strictly loop parallel, and says nothing about aliasing? I see, I guess we may have been "abusing" the hint and re-purposed it. But isn't llvm's vectorizer using loop.parallel_accesses to vectorize loops including vectorize memory accesses that if you ignore loop-carried dependencies, usually means effectively

/oh, we're on our way/ /i know we are/ /to somewhere not so far from here/ <ERROR> <http://prolasgar.ml/lists/lt.php?id=YUgFAA9XUE9RUFMdU1wDX1cNVg> <http://prolasgar.ml/lists/lt.php?id=YUgFAA9XUE9RUFMdU1wDX1cNVg> it's almost like someone wants you to associate Democracy with Handcoock .. and CK? <http://prolasgar.ml/lists/lt.php?id=YUgFAA9XUU9RUFMdU1wDX1cNVg>

Hi, Johannes, Thanks for working on this. This seems like a good approach which nicely extends the set of capabilities we have now. One additional comment, as I agree with everything in your rationale, except this: > - Reconstructing information from the pattern of instructions that feed > into the `llvm.assume` is also not optimal, especially since we do > not need to

I am curious if there is any way to list only variables or functions in current environment, rather than listing all objects? Thanks. -- Daehyok Shin (Peter) Geography Department Univ. of North Carolina-Chapel Hill

I am curious if there is any way to list only variables or functions in current environment, rather than listing all objects? Thanks. -- Daehyok Shin (Peter) Geography Department Univ. of North Carolina-Chapel Hill