similar to: [PATCH] ocfs2/quota: Release lock for error in ocfs2_quota_write.

Hi, I did some more in-depth testing of OCFS2 quota code, especially with ECC feature enabled and spotted some problems. First four patches fix them. I need the fifth patch to be able to mount OCFS2 filesystem with 2.6.31-rc3. The sixth patch fixes a potential problem when quota syncing interval is updated while the cluster is running (which is not possible currently). Joel, could you please

Hi, here is the second version of OCFS2 quota fixes with Joel's comments fixed. Also I've added a patch defining counts of credits for quota operations as Joel asked. Honza

There is an error path in ocfs2_quota_write() that doesn't unlock &gqinode->i_mutex(). That seems unintentional. Found by smatch (http://repo.or.cz/w/smatch.git). Compile tested. regards, dan carpenter Signed-off-by: Dan Carpenter <error27 at gmail.com> --- orig/fs/ocfs2/quota_global.c 2009-04-07 19:34:22.000000000 +0300 +++ devel/fs/ocfs2/quota_global.c 2009-04-07

Hi, I'm resending this patch series. It's rediffed against linux-next branch of Joel's git tree. The first four patches are obvious fixes of deadlocks in quota code and should go in as soon as possible. The other three patches implement lockdep support for OCFS2 cluster locks. So you can have a look whether the code make sence to you and possibly merge them. They should be NOP when

Hi Jan, I am now reading quota support in ocfs2 and have some qs. Wish you can help me clarify it. Thanks. ocfs2_quota_write: In the comment, you said that "we know the transaction is already started", so it should be called within a transaction. But in this function, we call ocfs2_extend_no_holes and ocfs2_simple_size_update which will start another transaction. So we can survive

Hi, This is the second batch of Ocfs2 patches intended for the merge window. The 1st batch were sent out previously: http://lkml.org/lkml/2008/12/19/280 The bulk of this set is comprised of Jan Kara's patches to add quota support to Ocfs2. Many of the quota patches are to generic code, which I carried to make merging of the Ocfs2 support easier. All of the non-ocfs2 patches should have

Signed-off-by: Joe Perches <joe at perches.com> --- fs/ocfs2/quota_global.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/ocfs2/quota_global.c b/fs/ocfs2/quota_global.c index edfa60c..05ed815 100644 --- a/fs/ocfs2/quota_global.c +++ b/fs/ocfs2/quota_global.c @@ -143,7 +143,7 @@ static int ocfs2_get_quota_block(struct inode *inode, int block, err = -EIO;

Hi, the first four patches in this series fix locking problems in OCFS2 quota code (three of them can lead to potential deadlocks). The fifth patch reorders ip_alloc_sem for directories to be acquired before localalloc locks. Mark would you please merge these? The last two patches implement lockdep annotations for OCFS2 cluster locks. We annotate all the cluster locks except for special ones

ocfs2_read_virt_blocks() does BUG when we try to read a block from a file beyond its end. Since this can happen due to filesystem corruption, it is not really an appropriate answer. Make ocfs2_read_quota_block() check the condition and handle it by calling ocfs2_error() and returning EIO. Reported-by: Tristan Ye <tristan.ye at oracle.com> Signed-off-by: Jan Kara <jack at suse.cz> ---

use i_size_read() instead of accessing inode->i_size directly. Signed-off-by: Wengang Wang <wen.gang.wang at oracle.com> -- diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c index b2c52b3..4491851 100644 --- a/fs/ocfs2/aops.c +++ b/fs/ocfs2/aops.c @@ -1920,7 +1920,7 @@ int ocfs2_write_end_nolock(struct address_space *mapping, out_write_size: pos += copied; - if (pos >

Hello, the following series of patches fixes some issues with OCFS2 quotas. The first patch modifies VFS quota locking, the next patch uses the fact to simplify OCFS2 quota locking and solves a few deadlock issues. The third and the fourth patches fix another possible deadlocks in OCFS2 quota code and the last patch is a minor cleanup. Honza

Linus, et al, Here are all the outstanding ocfs2 fixes for 2.6.31. The major fixes are for aio write and for non-sparse file extending. There are also a couple of b-tree fixes as well as some for quotas. Please pull. Joel The following changes since commit 44b572809581d5a10dbe35aa6bf689f32b9c5ad6: Yinghai Lu (1): x86: don't clear nodes_states[N_NORMAL_MEMORY] when numa is not

This patch implements functions and timer setup which handles periodic syncing of locally cached quota information to global quota file. Signed-off-by: Jan Kara <jack at suse.cz> --- fs/ocfs2/quota.h | 3 ++ fs/ocfs2/quota_global.c | 66 +++++++++++++++++++++++++++++++++++++++++++++++ fs/ocfs2/quota_local.c | 4 +++ 3 files changed, 73 insertions(+), 0 deletions(-) diff

Hello, the following patch series implements quotas for OCFS2. The patch series is based on: git://git.kernel.org/pub/scm/linux/kernel/git/mfasheh/ocfs2.git linux-next I've adressed Joel's comments, also node recovery is now fully working and I've fixed a few issues I found during my testing. So I'm currently not aware of any bugs. Please review, test, comment. Thanks.

Hi, All, When mount ocfs2 with option usrquota and grpquota, we will see below message: (mount.ocfs2,9434,1):ocfs2_global_read_info:403 ERROR: status = 24 (mount.ocfs2,9434,3):ocfs2_global_read_info:403 ERROR: status = 24 But actually this should not be a error. In ocfs2_global_read_info, if read_quota() succeed, status is the size of the struct ocfs2_global_disk_dqinfo, only when it is not

This version fixes three bugs in the 2nd patch of this series that caused kernel BUG when the system was under race. We weren't accounting with t_oustanding_credits correctly, and there were race conditions caused by the fact the I had overlooked the fact that __jbd2_log_wait_for_space() and jbd2_get_transaction() requires j_state_lock to be write locked. Theodore Ts'o (3): jbd2: Use

Hi. I got following BUG trace. This is violation of BUG_ON(!buffer_locked(bh)) check on submit_bh() function. In write_dev_supers(), if wait parameter is set and buffer_uptodate() check is negative, submit_bh() is executed and hit above BUG_ON. So I fixed this issue. Thanks. Jun 9 00:41:32 dl580 kernel: ------------[ cut here ]------------ Jun 9 00:41:32 dl580 kernel: kernel BUG at

Please pull from 'upstream-linus' branch of git://git.kernel.org/pub/scm/linux/kernel/git/mfasheh/ocfs2.git upstream-linus to receive the following updates: fs/configfs/dir.c | 59 +++++++++++++++++++++++++++++++++++++++++++++++ fs/ocfs2/alloc.c | 3 ++ fs/ocfs2/dcache.c | 42 +++++++++++++++++++++++++++++++-- fs/ocfs2/dcache.h | 9 ++++++-

Linus, et al, Here are the ocfs2 updates for 2.6.31. It's a quiet cycle, almost completely composed of fixes. There is a nice performance improvement from Hisashi Hifumi for fdatasync. Please pull. Joel The following changes since commit b4348f32dae3cb6eb4bc21c7ed8f76c0b11e9d6a: Linus Torvalds (1): Merge branch 'for-linus' of git://oss.sgi.com/xfs/xfs are available in

Linus, et al, Here are the major ocfs2 fixes for 2.6.35-rc5. A few more fixes have trickled in, but as these major fixes have been tested, I didn't want to delay them any longer. The first major fix you know about: the tail zeroing fix when extending files. It's been run under heavy testing for a week now, and we're quite happy. We should also no longer be touching any pages past