similar to: win32-clipboard issues and support for additional formats

On 09/21/2012 05:52 AM, Martinez, Javier E wrote: > The proposal comments have largely centered on the string functions. Do > people feel the same way about memcpy_s? What about those of you > building LLVM on Windows with Visual Studio? Is memcmp_s (or a variant thereof) a win in practice? It covers the case pretty well where you try to copy a dynamically sized buffer to the start

>From the responses it's pretty clear that the preference is to avoid using C string functions altogether. I've attached at list of calls in Clang/LLVM. The EASY/MEDIUM/DIFFICULT tag is an estimate of the effort to replace the call based on the location of the source buffer. If there are no objections I'll prepare a patch that replaces the string manipulation functions an

Hello, We have identified functions in LLVM sources using a static code analyzer which are marked as a "security vulnerability"[1][2]. There has been work already done to address some of them for Linux (e.g. snprintf). We are attempting to solve this issue in a comprehensive fashion across all platforms. Most of the functions identified are for manipulating strings. Memcpy is the most

Florian, You have a valid point, the majority of the times memcpy is used correctly and the destination buffer size is redundant information. I think we also agree that there are cases where the correct use of memcpy is not clear cut and the 4-parameter version adds value. I've modified the original proposal to strike the middle of the road. Instead of only providing a 4-parameter version of

Martinez, Javier E wrote: > Hello, > > We have identified functions in LLVM sources using a static code > analyzer which are marked as a “security vulnerability”[1][2]. There has > been work already done to address some of them for Linux (e.g. > snprintf). We are attempting to solve this issue in a comprehensive > fashion across all platforms. Most of the functions identified

I generally disagree with the approach. Generally char* strings aren't recommended for use in LLVM and this kind of string manipulation in LLVM shouldn't be done with the primitive C library functions. The Programmer's Manual gives the preferred types to use for strings [1] and all of them keep track of length. There are also safe routines for creating and formatting strings, such as

On Thu, Sep 20, 2012 at 10:13 AM, Chris Lattner <clattner at apple.com> wrote: > > On Sep 20, 2012, at 3:01 AM, Dmitri Gribenko <gribozavr at gmail.com> wrote: > > > On Wed, Sep 19, 2012 at 3:00 AM, Martinez, Javier E > > <javier.e.martinez at intel.com> wrote: > >> We have identified functions in LLVM sources using a static code > analyzer >

Hi Sean, Thanks for the valued feedback. I agree with you that the containers available in LLVM are preferable to char buffers but I want to point out that the proposal doesn't add any new uses of char buffer and merely works with existing ones. Changing existing uses of char buffers to other objects is beyond the scope of this proposal. It makes more sense to do that when changes to code

On Sep 20, 2012, at 3:01 AM, Dmitri Gribenko <gribozavr at gmail.com> wrote: > On Wed, Sep 19, 2012 at 3:00 AM, Martinez, Javier E > <javier.e.martinez at intel.com> wrote: >> We have identified functions in LLVM sources using a static code analyzer >> which are marked as a “security vulnerability”[1][2]. There has been work >> already done to address some of

> I’ll prepare a patch that replaces the string manipulation functions an > appropriate string object. Please break the patch up into focused chunks, one per logical change. We try to keep all LLVM development as incremental as possible [1]. I recommend fixing a single logical occurrence (such as fixing APFloat::convertToHexString()) and then mailing the patch to llvm-commits. It's

Full_Name: Liam Gretton Version: 2.9.2 OS: openSUSE 11.1 (x86_64) Submission from: (NULL) (143.210.13.77) Reading a large number of rows of delimited data via the clipboard results in a segfault or double free error. I've tested copying from various applications, but gedit will do. This problem exists in the openSUSE-supplied 2.8.1, I've just built 2.9.2 to see if it's still there,

Bugs item #5287, was opened at 2006-08-03 08:34 You can respond by visiting: http://rubyforge.org/tracker/?func=detail&atid=411&aid=5287&group_id=85 Category: win32-clipboard Group: Code >Status: Closed >Resolution: Rejected Priority: 3 Submitted By: Nobody (None) Assigned to: Nobody (None) Summary: v 0.4.1 - Clipboard.set_data causes Segmentation fault Initial Comment:

Bugs item #5287, was opened at 2006-08-03 11:34 You can respond by visiting: http://rubyforge.org/tracker/?func=detail&atid=411&aid=5287&group_id=85 Category: win32-clipboard Group: Code Status: Open Resolution: None Priority: 3 Submitted By: Nobody (None) Assigned to: Nobody (None) Summary: v 0.4.1 - Clipboard.set_data causes Segmentation fault Initial Comment: Whenever

Hi all, In CVS you''ll find a clipboard.rb file. I hadn''t touched it in a while until recently. However, it doesn''t seem to actually work. Calling set_data doesn''t fail, but it doesn''t actually seem to set the clipboard data. Any ideas? Thanks, Dan

Hi all I''m having a go at porting the Clipboard and DnD classes, going OK, but have hit a snag where I could use your help. I''ve added several relevant classes, but now I have on OS X missing symbols: wxDataObjectBase::GetDataHere(wxDataFormat const&, void*) const wxDataObjectBase::GetDataSize(wxDataFormat const&) const DataObjectBase is an internal base class for

Hello R-Help, I noticed that there is a thread about importing data from the clipboard that is very poorly answered in the forum. One user suggests giving up, the other gives a solution that echoes the clipboard, but that's exactly the same as just ctrl-p. As I am asked this question at least once a week in my very small home institution, I'm sure many people want to know. If you could

Hi every one, I'm having some problems with the function read.table(clipboard). I got a spread sheet in the Excel, and than I make a command+C in the Mac, but the R returns the message that there is no object in the clipboard. What could have happened? Thanks, Diogo [[alternative HTML version deleted]]

Hi all, Is there a cross-platform way to do this? On the mac, I cando this by saving an eps file, and then using pbcopy. Is it possible on other platforms? Hadley -- http://had.co.nz/

When I try to copy a piece of text from any X application and paste it in application running under Wine (e.g. Notepad), the russian characters (believe any cyrillic characters) got messed up and are replaced by some kind of unicode characters (e.g.\x{043F}\x{0440}\x{043E}\x{0431}\x{043B}\x{0435}\x{043C}\H). The system locale is KOI8-R, using RedHat FedoraCore 1.0 and wine-20040213. Thank you for

Is there a way to copy selected text from the X11 Clipboard to Wine? The other way (wine -> x) works fine. Tsch??, Wolfgang -- Wolfgang Becker *** eMail uafr@gmx.de http://www.uni-karlsruhe.de/~Wolfgang.Becker/