similar to: [PATCH] lguest: properly kill guest userspace programs accessing kernel mem

From: Rusty Russell <rusty@rustcorp.com.au> This is the code for the "lg.ko" module, which allows lguest guests to be launched. [akpm@linux-foundation.org: update for futex-new-private-futexes] Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Cc: Andi Kleen <ak@suse.de> Cc: Eric Dumazet <dada1@cosmosbay.com> Signed-off-by: Andrew Morton

From: Rusty Russell <rusty@rustcorp.com.au> This is the code for the "lg.ko" module, which allows lguest guests to be launched. [akpm@linux-foundation.org: update for futex-new-private-futexes] Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Cc: Andi Kleen <ak@suse.de> Cc: Eric Dumazet <dada1@cosmosbay.com> Signed-off-by: Andrew Morton

[Bug that was found by my previous patch] This patch allows things like modules, which don't have a direct __pa(EIP) mapping to do emulated instructions. Sure, the emulated instruction probably should be a paravirt_op, but this patch lets you at least boot a kernel that has modules needing emulated instructions. Signed-off-by: Steven Rostedt <rostedt@goodmis.org> Index:

[Bug that was found by my previous patch] This patch allows things like modules, which don't have a direct __pa(EIP) mapping to do emulated instructions. Sure, the emulated instruction probably should be a paravirt_op, but this patch lets you at least boot a kernel that has modules needing emulated instructions. Signed-off-by: Steven Rostedt <rostedt@goodmis.org> Index:

Hi, this version requires that host and guest have the same PAE status. NX cap is not offered to the guest, yet. Thanks, Matias Lguest PAE support Signed-off-by: Matias Zabaljauregui <zabaljauregui at gmail.com> --- Documentation/lguest/lguest.txt | 1 - arch/x86/include/asm/lguest.h | 7 +- arch/x86/include/asm/lguest_hcall.h | 3 +- arch/x86/lguest/Kconfig

Hi, this version requires that host and guest have the same PAE status. NX cap is not offered to the guest, yet. Thanks, Matias Lguest PAE support Signed-off-by: Matias Zabaljauregui <zabaljauregui at gmail.com> --- Documentation/lguest/lguest.txt | 1 - arch/x86/include/asm/lguest.h | 7 +- arch/x86/include/asm/lguest_hcall.h | 3 +- arch/x86/lguest/Kconfig

We don't actually need the Guest handlers mapped to avoid double fault, just the stack pages. Thanks to Zach for confirming. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> --- drivers/lguest/interrupts_and_traps.c | 26 +------------------------- drivers/lguest/lg.h | 2 +- drivers/lguest/page_tables.c | 6 +++--- 3 files changed, 5

We don't actually need the Guest handlers mapped to avoid double fault, just the stack pages. Thanks to Zach for confirming. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> --- drivers/lguest/interrupts_and_traps.c | 26 +------------------------- drivers/lguest/lg.h | 2 +- drivers/lguest/page_tables.c | 6 +++--- 3 files changed, 5

Hi, For some days I have been looking for the bug that causes an easily reproducible oops in the guest when I apply my PAE support _draft_ patch (appended at the end of this mail) to lguest. This is the oops: Setting kernel variables...done. Will now mount local filesystems:. Will now activate swapfile swap:done. Cleaning /tmp... [ 84.749676] BUG: unable to handle kernel NULL pointer

Hi, For some days I have been looking for the bug that causes an easily reproducible oops in the guest when I apply my PAE support _draft_ patch (appended at the end of this mail) to lguest. This is the oops: Setting kernel variables...done. Will now mount local filesystems:. Will now activate swapfile swap:done. Cleaning /tmp... [ 84.749676] BUG: unable to handle kernel NULL pointer

If we're building a pte, we can use simple assigment; only use set_pte etc. when we're actually going to use that destination as a PTE. I don't know that we'll ever run under Xen, but it's neater. And use set_pte/set_pmd rather than assuming native_ versions, even though that's probably true for most people. (Includes compile fix by Kamalesh Babulal <kamalesh at

If we're building a pte, we can use simple assigment; only use set_pte etc. when we're actually going to use that destination as a PTE. I don't know that we'll ever run under Xen, but it's neater. And use set_pte/set_pmd rather than assuming native_ versions, even though that's probably true for most people. (Includes compile fix by Kamalesh Babulal <kamalesh at

Impact: potential bugfix In theory, the kernel could reuse the same page as pgdir for a new process while the hypervisor keeps it cached. This would have undesirable results. Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> --- arch/x86/include/asm/lguest_hcall.h | 1 + arch/x86/lguest/boot.c | 8 ++++++++ drivers/lguest/hypercalls.c | 3 +++

Impact: potential bugfix In theory, the kernel could reuse the same page as pgdir for a new process while the hypervisor keeps it cached. This would have undesirable results. Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> --- arch/x86/include/asm/lguest_hcall.h | 1 + arch/x86/lguest/boot.c | 8 ++++++++ drivers/lguest/hypercalls.c | 3 +++

plain text document attachment (lguest64.patch) This is the main core code for the lguest64. Have fun, and don't hurt the puppies! Signed-off-by: Steven Rostedt <srostedt@redhat.com> Signed-off-by: Glauber de Oliveira Costa <glommer@gmail.com> Cc: Chris Wright <chrisw@sous-sol.org> Index: work-pv/arch/x86_64/lguest/Makefile

plain text document attachment (lguest64.patch) This is the main core code for the lguest64. Have fun, and don't hurt the puppies! Signed-off-by: Steven Rostedt <srostedt@redhat.com> Signed-off-by: Glauber de Oliveira Costa <glommer@gmail.com> Cc: Chris Wright <chrisw@sous-sol.org> Index: work-pv/arch/x86_64/lguest/Makefile

This series takes one more step towards cpu-ification of lguest. As for rusty's last suggestion, I get rid of the whole bunch of "struct lguest *lg = cpu->lg" statements around by using lg_cpu as our base structure wherever it matters. (this saves us 11 lines)

This series takes one more step towards cpu-ification of lguest. As for rusty's last suggestion, I get rid of the whole bunch of "struct lguest *lg = cpu->lg" statements around by using lg_cpu as our base structure wherever it matters. (this saves us 11 lines)

Hi, In many places xen uses "unsigned long" instead of the l*_pgentry_t types to pass around page table entries. Here is a patch which fixes this in a number of places (mostly in shadow mode code). Thats what I''ve trapped in so far, maybe more of these patches follow. Fixing this is needed for adding PAE support to xen. In PAE paging mode the page table entries are 64 bit

Christoph Hellwig said runs sparse: 1) page_tables.c unnecessary initialization 2) Change prototype of run_lguest and do cast in caller instead (when we add __user to cast, it runs over another line). Al Viro pointed out the ugly cast in push_lguest_stack(): 3) Stick with unsigned long for arg, removes 4 casts in total. Most importantly, I now realize that Christoph's incorrect ranting